1457216 - Remove support for editable menulists

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P1)

Description

[Tim Nguyen :ntim]

It doesn't seem to be used in m-c: https://dxr.mozilla.org/mozilla-central/search?q=menulist+%22editable%22+%22true%22&redirect=false

Comment 1

[Tim Nguyen :ntim]

Allows getting rid of the menulist-editable binding.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: code cleanup.

Comment 3

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a3488a02d9cb4a5d826fc56ced3394b50eab8a9

Comment 4

[:Paolo Amadini]

Attachment: Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 9004134 [details]
Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins

Brian Grinstead [:bgrins] has approved the revision.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Tim Nguyen :ntim from comment #0)
> It doesn't seem to be used in m-c:
> https://dxr.mozilla.org/mozilla-central/
> search?q=menulist+%22editable%22+%22true%22&redirect=false

It is still used in thunderbird, https://dxr.mozilla.org/comm-central/search?q=menulist+%22editable%22+%22true%22&redirect=true. Needless to say it will make thunderbird less accessible by accepting the change. How do we address such conflicts?

Comment 7

[:Paolo Amadini]

At the moment, the Thunderbird developers have a bug on file for every widget removal that we are doing in mozilla-central. The most common strategies for dealing with the removals are, at this stage of the project, either to migrate away from the widget or to port the XBL binding to comm-central. The latter seems to be the strategy that's been followed in bug 1486051. Unless Thunderbird starts porting platform code as well, this just delays the eventual need to migrate away from the widget when we remove XBL support entirely. As far as I know there is no final decision on whether any platform code will be ported or not.

Knowing the impact of the changes we're making may help the Thunderbird developers with deciding a strategy for each bug they have on file. In this case, maybe you can comment in bug 1486051 to clarify the effect of the platform code changes in this patch on the binding that's been added to comm-central? If this makes parts of the user interface inaccessibile, an option may be to port those places to the "autocomplete" widget, or add some glue code to work around the new platform behavior.

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 9004134 [details]
Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins

alexander :surkov (:asurkov) has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20db845c4c87
Remove support for editable menulists. r=surkov,bgrins

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/20db845c4c87