Closed Bug 1457297 Opened 2 years ago Closed 2 years ago

Enable shape-outside for all channels

Categories

(Core :: Layout: Floats, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: mreavy, Assigned: bradwerth)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Shape-outside is pref'd on in Nightly, but not Beta and Release for Fx 61.  This bug tracks enabling Shapes-outside for all revisions.  We should land this early in Fx 62.
Priority: -- → P3
Hi Brad -- Since Nightly is now Firefox 62, we need to enable for all revisions.  Do you agree the feature is ready to ride the trains?  If so, can you land the patch to enable it this week?
Flags: needinfo?(bwerth)
Priority: P3 → P1
This is a new feature, so the priority is officially a P2, but we *definitely* want this in 62.  (Thanks, Brad!)
Priority: P1 → P2
Summary: Enable shape-outside for all revisions → Enable shape-outside for all channels
Assignee: nobody → bwerth
Flags: needinfo?(bwerth)
Attachment #8974546 - Flags: review?(dbaron)
Are there shared tests of shape-outside in web-platform-tests?  If so, are there any that we fail, and what bugs correspond to those failures?

Is the entire feature implemented, or are there missing pieces?  If so, what bugs correspond to those pieces?

Did you send an intent-to-ship to dev-platform?  See https://wiki.mozilla.org/ExposureGuidelines .
Flags: needinfo?(bwerth)
Comment on attachment 8974546 [details]
Bug 1457297: Turn pref layout.css.shape-outside.enabled on by default for all channels.

https://reviewboard.mozilla.org/r/242890/#review249134

Please re-request review after answering the questions above.
Attachment #8974546 - Flags: review?(dbaron)
Blocks: 1466125
(In reply to David Baron :dbaron: ⌚UTC-7 from comment #4)
> Are there shared tests of shape-outside in web-platform-tests?  If so, are
> there any that we fail, and what bugs correspond to those failures?

We do still fail some tests, but they don't have associated bugs:

/css/css-shapes/shape-outside/shape-image/shape-image-024.html - our PNG upscaling doesn't create a clean edge pixel, and it introduces a sub-pixel shift in the final placement.
css/css-shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004.html.ini - our radial gradient generation doesn't exactly match expectations and introduces sub-pixel placement defects.
css/css-shapes/spec-examples/shape-outside-008.html - our detection against a polygon is off by sub-pixel amounts.

All of the above are cases where we've got minor fuzziness in the final placement. WPT don't allow for fuzzy matches. If they did, we'd likely pass.

css/css-shapes/spec-examples/shape-outside-004.html - we've intentionally deviated from spec here in anticipation of the spec changing, see Bug 1461046.

> Is the entire feature implemented, or are there missing pieces?  If so, what
> bugs correspond to those pieces?

There are two pending bugs, and they both are blocking the main meta-bug Bug 1098939:
Bug 1466231 - Inline frames without enough inline space should clear floats, regardless of shape-outside. This has knock-on effects in non shape-outside tests that are still being worked through.
Bug 1463745 - The Text around shape-outside does not fill the empty space [shape-outside]. This is a simpler case that has tests that depend on the previous bug, but is otherwise ready to land.

> Did you send an intent-to-ship to dev-platform?  See
> https://wiki.mozilla.org/ExposureGuidelines .

I have just done so. I set a target for landing this bug on Monday June 11th.
Flags: needinfo?(bwerth)
Attachment #8974546 - Flags: review?(dbaron)
Comment on attachment 8974546 [details]
Bug 1457297: Turn pref layout.css.shape-outside.enabled on by default for all channels.

https://reviewboard.mozilla.org/r/242890/#review257398
Attachment #8974546 - Flags: review?(dbaron) → review+
Thank you. I'll attempt landing now.
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9641e4d0f4c
Turn pref layout.css.shape-outside.enabled on by default for all channels. r=dbaron
https://hg.mozilla.org/mozilla-central/rev/f9641e4d0f4c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
I've updated the compat data for shape-outside, shape-margin, and shape-image-threshold:

https://developer.mozilla.org/en-US/docs/Web/CSS/shape-outside
https://developer.mozilla.org/en-US/docs/Web/CSS/shape-margin
https://developer.mozilla.org/en-US/docs/Web/CSS/shape-image-threshold

I think that's all we need here, so I'm marking this dev-doc-complete, but please let me know if we need anything else.
You need to log in before you can comment on or make changes to this bug.