1457335 - histography.io blocks Firefox

Status: REOPENED

(Web Compatibility :: Site Reports, enhancement, P3)

Description

[Adam Stevenson [:adamopenweb]]

Originally filed: https://github.com/webcompat/web-bugs/issues/1804

The site doesn't allow Firefox and contacts have not been successful. It is ranked 285,224 in the U.S, which isn't very high but it would be good for this site to actually work for Firefox users.

Detection code:
var nt = /Chrome/.test(navigator.userAgent) && /Google Inc/.test(navigator.vendor),
        at = /Safari/.test(navigator.userAgent) && /Apple Computer/.test(navigator.vendor),
        it = /Safari/.test(navigator.userAgent) && /Googlebot/.test(navigator.vendor),
        rt = {
            Android: function() {
                return navigator.userAgent.match(/Android/i)
            },
            BlackBerry: function() {
                return navigator.userAgent.match(/BlackBerry/i)
            },
            iOS: function() {
                return navigator.userAgent.match(/iPhone|iPad|iPod/i)
            },
            Opera: function() {
                return navigator.userAgent.match(/Opera Mini/i)
            },
            Windows: function() {
                return navigator.userAgent.match(/IEMobile/i)
            },
            any: function() {
                return rt.Android() || rt.BlackBerry() || rt.iOS() || rt.Opera() || rt.Windows()
            }
        };
    rt.any() && (window.location = "mobile.htm"), nt || at || it || (window.location = "browser_support.htm");

Since we do not support navigator.vendor, I'm guessing we'll need to inject JS to override.

Comment 1

[Dennis Schubert [:denschub]]

Attachment: Pull Request #23

This PR implement a UA override, so Firefox users can enjoy the site as well!

Comment 2

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 8988660 [details] [diff] [review]
Pull Request #23

Review of attachment 8988660 [details] [diff] [review]:
-----------------------------------------------------------------

r+ (notes on GitHub)

Comment 3

[Dennis Schubert [:denschub]]

Site patch is landed in our repo on GitHub, so this can be closed. Landing the site patches (and eventually updating Release users via GoFaster) is tracked in 1481395.

Comment 4

[Karl Dubost💡 :karlcow]

FYI The site is broken again even with the user agent override.
See https://webcompat.com/issues/20523 for new diagnosis.

Comment 5

[Thomas Wisniewski [:twisniewski]]

Reopening this one, since we're now tracking the status of webcompat issues with interventions differently.

Comment 6

[Dennis Schubert [:denschub]]

Mass-assigning diagnosis-team to webcompat for "Firefox is not supported" bugs that don't already have a team assigned. This action is done by a script. For your convenience, feel free to filter your bugmail with 559a9604-41ec-11f0-9ec6-f3f21dcd7cf2.