1457395 - Misspelled "proces" in source codes

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[YUKI "Piro" Hiroshi]

I've found misspelled "proces" in sources. They should be spelled as "process".
https://dxr.mozilla.org/mozilla-central/search?q=proces++-process+-prproces+-uxproces+-path%3Athird_party+-file%3Afeed+-file%3Adictionary+-file%3Adic+-path%3Achromium+-path%3Awebrtc%2Ftrunk+-path%3Askia&redirect=false

Note: I've realized that there are two functions including the typo, but I couldn't find out any code referring them.
https://dxr.mozilla.org/mozilla-central/source/netwerk/srtp/src/include/ekt.h#149
https://dxr.mozilla.org/mozilla-central/source/netwerk/srtp/src/include/ekt.h#153
So I think they should be kept as-is, for backward compatibility.


Steps to reproduce: None.
Expected result: There is no typo.
Actual result: There is misspelled "proces".

Comment 1

[YUKI "Piro" Hiroshi]

Attachment: Patch for mozilla-central

This patch fixes misspelled "proces" in comments.

Comment 2

[YUKI "Piro" Hiroshi]

Attachment: Patch for mozilla-central, with necessary information

I've regenerated the patch with the command "hg export -r XXX:XXX".

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8974621 [details] [diff] [review]
Patch for mozilla-central, with necessary information

Review of attachment 8974621 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/TextInputHandler.mm
@@ +3751,5 @@
>  
>    MOZ_LOG(gLog, LogLevel::Info,
>      ("%p IMEInputHandler::MaybeDispatchKeydownEvent, aIsProcessedByIME=%s "
>       "currentKeyEvent={ mKeyEvent(%p)={ type=%s, keyCode=%s (0x%X) } }, "
> +     "aIsProcessedBy=%s, IsDeadKeyComposing()=%s",

Are there any tools that are expecting the misspelled string when automatically parsing the log perhaps?  I imagine not.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Yuki, the change in nsprpub needs to be landed upstream rather than in mozilla-central (we'll then pick up the change with an upstream import). I've removed it from this patch so the rest of it can land, but can you please file a follow-up NSPR bug for that change? Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf373243d213
Fix typo "proces" in comments. r=milan

Comment 6

[YUKI "Piro" Hiroshi]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
Thanks, I've filed the bug 1460820 for NSPR.

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/cf373243d213