1457937 - Context menu icons break vertical text layout

Status: NEW

(Core :: XUL, defect, P3)

Description

[❌ PTO, back 5 Jan ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: screenshot showing "Take a screenshot" text offset to the right

Originally reported as https://github.com/mozilla-services/screenshots/issues/4375:

When a webextension context menu item is displayed with an icon on Mac OS (and maybe other platforms), the left edge of the text is indented relative to the other, non-webextension context menu items.

It would be nice if the text lined up when icons were present, which is the behavior in the page action doorhanger.

I'll attach a screenshot of the context menu on Mac, and the page action doorhanger with one menu item that has an icon, and one menu item that doesn't.

Comment 1

[❌ PTO, back 5 Jan ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: screenshot showing aligned text in the page action doorhanger

Comment 2

[David Durst [:ddurst]]

Looking for some guidance on what the feel should be on this. We seem to see a mix of these (at least on MacOS).

Comment 3

[Stephen Horlander [:shorlander]]

Generally on macOS all the items in the menu are left aligned.

In a native menu that mixes label and icon+label items the icons and the text would be aligned with each other:

[label]
-----------
[i] [label]

Not:

    [label]
-----------
[i] [label]

Which is to say that our current context menus are doing the "right thing".

However menu items on macOS usually only use an icon to represent things (e.g. a folder, a file, an application) and not actions (e.g. back, forward, screenshot). So we are deviating in that respect.

Panels are not technically menus, but if we were to change something for consistency I would make panel lists match the context menu layout.

Bryan designed those, so he might have opinions.

Comment 4

[Shane Caraveo (:mixedpuppy)]

That's kind of what I thought.  I think this is a style issue in general, nothing to do with extensions.  As well, this is a decision on the ux team about whether and what to do with it.  Pushing it over to Firefox:untriagged.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.