On Linux, when menu items of type radio/checkbox have an icon, the icon is shown above the checkbox/radio input. For example, let's say that [ ] and ( ) are checkbox/radio elements, and X is an icon. On macOS, menu items are rendered as follows: [ ] X title 1 ( ) title 2 Note that the first title is shifted to the right to make space for the icon. On Linux, the same menu items are rendered as follows: [X] title 1 ( ) title 2 Note that the X and [ ] are rendered on top of each other, and that the titles always have the same alignment. A variant of this issue was reported before in bug 1351418. That bug was patched by always moving checkbox menu items into a submenu, but that was before bug 1321544 introduced support for icons on submenu items.
1. Load extension, e.g. at about:debugging . 2. Right-click on the page and hover over the "Extension menu items" menu item at the bottom to show the submenu. Expected (e.g. on macOS): - The icons should clearly be seen. - The radio/checkbox elements should clearly be shown on the menu items. Actual (Linux): - The radio/checkbox elements are obscured by the icon.
Screenshot taken on Linux. The icon (red cross) clearly overlaps with the radio/checkbox elements.
PS. I accidentally exchanged the menu labels in the test case. "[type] with icon" has no icon (contrary to what the menu label claims). "[type]" has an icon. This does not affect the validity of the test case though.
This issue is also seen at menu items in the View > Sidebar main menu for sidebar extensions. STR: 1. Load sidebar extension, e.g. from bug 1493396. 2. Open the menu (maybe press Alt to show it), View > Sidebar. Expected: - The icon should not overlap with the checkbox. Actual: - An (auto-generated, default) icon overlaps with the checkbox before the extension.
The behavior varies by platform (tested with Firefox 62): - macOS: Icon prepended to menu label. This appearance might be buggy according to bug 1457937 - Linux: Icon overlaps with radio/checkbox (comment 2 / comment 4). - Windows: Icon not shown if menu item has radio/checkbox (even if not checked). Let's wait for a resolution on the desired behavior of menus (bug 1457937) before moving forwards with this bug.
Depends on: 1457937
NI shorlander on this (similar/related to bug 1457937). Note especially #c5 and the screenshots. While icons in this context are rare, the collision is bad and not showing the icon seems strange; having a design aberration in this edge case makes sense to me, but... I am no designer.
Moving NI to emanuela because time.
Flags: needinfo?(shorlander) → needinfo?(emanuela)
Flags: needinfo?(emanuela) → needinfo?(ddurst)
Flags: needinfo?(ddurst) → needinfo?(rob)
You need to log in before you can comment on or make changes to this bug.