1457999 - Refactor command line parsing and safe mode detection

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

We need to parse some command line args and detect safe mode from within firefox.exe.

We should make that code common between firefox.exe and toolkit so that there is one source of truth.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Part 1: Move command line argument utils and safe mode checks into a common header file

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Part 2 - Change updater and maintenance service to use changes made in part 1

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8972108 [details] [diff] [review]
Part 1: Move command line argument utils and safe mode checks into a common header file

Review of attachment 8972108 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent clean up work, thanks.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d838002f9a52e28797b27c7aa0e58b9cccc06d93
Bug 1457999: Part 1 - Move command line argument utils and safe mode checks into a common header file; r=jimm

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d72ee6c1126c4c7d7d372ac2adca609e4dfa545
Bug 1457999: Part 2 - Update the updater and maintenance service with changes made in part 1; r=mhowell

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82cc108f33b8fb0af5f068a46c0d21cd81e908ed
Bug 1457999: Backed out changeset 5d72ee6c1126 due to Linux preprocessor errors; r=backout CLOSED TREE

https://hg.mozilla.org/integration/mozilla-inbound/rev/5486a5777bbdecd3da01cbc5c6beee86192fa7aa
Bug 1457999: Backed out changeset d838002f9a52 due to Linux preprocessor errors; r=backout CLOSED TREE

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b3a2ae3a6d36abd6f0bb79a265015ff6edd1c87
Bug 1457999: Part 1 - Move command line argument utils and safe mode checks into a common header file; r=jimm

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc8e373f027c401130c1e86821febec862cb0caf
Bug 1457999: Part 2 - Update the updater and maintenance service with changes made in part 1; r=mhowell

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffce5dda747f3e5fb1d0e1d4fac6f7f1940c9155
Bug 1457999: Backed out changeset fc8e373f027c for Linux bustage; r=backout CLOSED TREE

https://hg.mozilla.org/integration/mozilla-inbound/rev/bac03a25bfa321708faaabe48a33263b82533625
Bug 1457999: Backed out changeset 3b3a2ae3a6d3 due to Linux bustage; r=backout CLOSED TREE

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48efb6a703ce1213079e453ea6cabda0d4ec63e1
Bug 1457999: Part 1 - Move command line argument utils and safe mode checks into a common header file; r=jimm

https://hg.mozilla.org/integration/mozilla-inbound/rev/eceb8bb354b7003920d129d0ecbb1d11169bfbec
Bug 1457999: Part 2 - Update the updater and maintenance service with changes made in part 1; r=mhowell

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d838002f9a52
https://hg.mozilla.org/mozilla-central/rev/5d72ee6c1126
https://hg.mozilla.org/mozilla-central/rev/82cc108f33b8
https://hg.mozilla.org/mozilla-central/rev/5486a5777bbd
https://hg.mozilla.org/mozilla-central/rev/3b3a2ae3a6d3
https://hg.mozilla.org/mozilla-central/rev/fc8e373f027c
https://hg.mozilla.org/mozilla-central/rev/ffce5dda747f
https://hg.mozilla.org/mozilla-central/rev/bac03a25bfa3

Comment 10

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e22518b7790ca314bdef2ff3e410ff5701408726
Bug 1457999: Follow-up - update Valgrind intentional leak whitelist to reflect updated name of mozilla::SaveToEnv; r=bustage

Comment 11

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/634a505843ded8b10a68c6d535c841aa0d625bdb
Bug 1457999: Update Valgrind intentional leak whitelist to include undecorated SaveToEnv; r=bustage

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/48efb6a703ce
https://hg.mozilla.org/mozilla-central/rev/eceb8bb354b7
https://hg.mozilla.org/mozilla-central/rev/e22518b7790c
https://hg.mozilla.org/mozilla-central/rev/634a505843de