Closed Bug 1454745 Opened 3 years ago Closed 3 years ago

Skeletal bootstrap process

Categories

(Firefox :: General, enhancement, P2)

Unspecified
Windows
enhancement

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

(Whiteboard: inj+)

Attachments

(1 file)

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1435780#c1

This bug should just involve adding the command-line flag and basic infra for doing a bootstrap. We'll add the actual policies etc in follow-up bugs.
Depends on: 1457999
This is the just the essentials that allow us to test bootstrapping by specifying --launcher on the command line. We'll add policies and blocklist setup in follow-up bugs.
Attachment #8972147 - Flags: review?(jmathies)
Blocks: 1458386
Comment on attachment 8972147 [details] [diff] [review]
Skeletal bootstrap process

Moving this to Matt as per PlatInt meeting today.
Attachment #8972147 - Flags: review?(jmathies) → review?(mhowell)
Comment on attachment 8972147 [details] [diff] [review]
Skeletal bootstrap process

Review of attachment 8972147 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good. Just a couple small points.

I thought about maybe adding some tests for this patch, but I feel like we're good without any, since we'll have plenty of testing of how the bootstrap process is working out when it's made the default behavior, and anyway I'm not sure how to verify "passing a particular command-line flag has no observable effect", which is what the test for this patch would boil down to.

::: browser/app/LauncherProcessWin.cpp
@@ +57,5 @@
> +  if (!result) {
> +    return;
> +  }
> +
> +  ::MessageBoxW(nullptr, rawMsgBuf, L"Firefox", MB_OK | MB_ICONERROR);

I don't love hard-coding "Firefox" here, but I don't have a good way to avoid it, so I'll have to live with it.

@@ +69,5 @@
> +bool
> +RunAsLauncherProcess(int& argc, wchar_t** argv)
> +{
> +  return CheckArg(argc, argv, L"launcher",
> +                  reinterpret_cast<const wchar_t**>(nullptr),

I tried to build this patch in Clang, and it wouldn't compile this cast; apparently the language spec doesn't allow reinterpret_casts from nullptr. It seems to only want to take a static_cast.
Attachment #8972147 - Flags: review?(mhowell) → review+
https://hg.mozilla.org/mozilla-central/rev/eb5c30217df9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.