1458018 - Style multiselected tabs based on spec from UX

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

UX will be providing a spec for how multiselected tabs should appear. This bug will build on the work from bug 1458010 to change from using bold tab titles to the UX-designed styling.

Comment 1

[Abdoulaye O. LY]

Attachment: Bug 1458018 - Add style for multiselected tabs.

Review commit: https://reviewboard.mozilla.org/r/248726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248726/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8982905 [details]
Bug 1458018 - Add style for multiselected tabs.

https://reviewboard.mozilla.org/r/248726/#review255188

::: browser/base/content/tabbrowser.xml:301
(Diff revision 1)
>            if (hoveredTab) {
>              hoveredTab._mouseenter();
>            }
> +
> +          // Update before-multiselected attributes.
> +          // gBrowser may not be inialised yet, so avoid using it

spelling, initialized (missing the 'ti' after 'in'). I searched the codebase and 'initialize' (en-US spelling) was found over 1,000 times while 'initialise' (en-GB spelling) was found 659 times.

::: browser/base/content/test/tabs/browser.ini:48
(Diff revision 1)
>  [browser_open_newtab_start_observer_notification.js]
>  [browser_bug_1387976_restore_lazy_tab_browser_muted_state.js]
>  [browser_multiselect_tabs_using_Ctrl.js]
>  [browser_multiselect_tabs_using_Shift.js]
>  [browser_multiselect_tabs_close.js]
> +[browser_multiselect_tabs_styling.js]

Can you rename this test to 'browser_multiselect_tabs_positional_attrs.js'?

Comment 3

[Abdoulaye O. LY]

Comment on attachment 8982905 [details]
Bug 1458018 - Add style for multiselected tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/248726/diff/1-2/

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 42dde73253debe23161e321a11610a2385c1ef03 -d 0943910146c4: rebasing 467305:42dde73253de "Bug 1458018 - Add style for multiselected tabs. r=jaws" (tip)
merging browser/base/content/tabbrowser.js
merging browser/base/content/tabbrowser.xml
merging browser/themes/shared/tabs.inc.css
warning: conflicts while merging browser/base/content/tabbrowser.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Abdoulaye O. LY]

Comment on attachment 8982905 [details]
Bug 1458018 - Add style for multiselected tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/248726/diff/2-3/

Comment 6

[Abdoulaye O. LY]

Comment on attachment 8982905 [details]
Bug 1458018 - Add style for multiselected tabs.

https://reviewboard.mozilla.org/r/248726/#review255188

Manual rebase done.

Comment 7

[Abdoulaye O. LY]

Comment on attachment 8982905 [details]
Bug 1458018 - Add style for multiselected tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/248726/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/693da404eaca
Add style for multiselected tabs. r=jaws

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/693da404eaca

Comment 10

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Verified fixed that this implementation is present on the latest Nightly Nightly 65.0a1(2018-11-22)and the latest Beta 64.0b11 as well .