Closed Bug 1458174 Opened 5 years ago Closed 5 years ago

Remove nsIDOMElement from SeaMonkey

Categories

(SeaMonkey :: General, enhancement, P2)

Product:
SeaMonkey
Component:
General
Platform:
All
Unspecified
Type:
enhancement

Tracking

(seamonkey2.58 fixed, seamonkey2.57esr unaffected)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.58
Tracking Flags:
Tracking Status
seamonkey2.58 --- fixed
seamonkey2.57esr --- unaffected

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

1458174-nsIDOMElement-V2.patch
14.46 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review
1458174-fix-1455674-port.patch
1.16 KB, patch
frg
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1455674 +++

nsIDOMElement has been removed. Tree is broken for all platforms because of this.
Attached patch 1458174-nsIDOMElement.patch (obsolete) — — Splinter Review 
Compile is running
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attached patch 1458174-nsIDOMElement.patch (obsolete) — — Splinter Review 
Rebased. macOS and Windows compile. Can't test Linux currently.
Attachment #8972273 - Attachment is obsolete: true
Attachment #8972382 - Flags: review?(iann_bugzilla)
nsGNOMEShellService.cpp was missing a "namespace mozilla" declaration. No other changes.
Attachment #8972382 - Attachment is obsolete: true
Attachment #8972382 - Flags: review?(iann_bugzilla)
Attachment #8972549 - Flags: review?(iann_bugzilla)
Comment on attachment 8972549 [details] [diff] [review]
1458174-nsIDOMElement-V2.patch

LGTM r=me
Attachment #8972549 - Flags: review?(iann_bugzilla) → review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e6f416a808eb
Remove nsIDOMElement from SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
status-seamonkey2.58: affected → fixed
Target Milestone: --- → Seamonkey2.58

Bill found an error in the original patch. r+ from me.

Attachment #9131860 - Flags: review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/3fd01064df4a
Remove nsIDOMElement from SeaMonkey. r=frg
See Also: → 1803918
You need to log in before you can comment on or make changes to this bug.