Closed Bug 1803918 Opened 3 years ago Closed 3 years ago

Website Navigation Bar has stopped working

Categories

(SeaMonkey :: Tabbed Browser, defect)

Product:
SeaMonkey
Component:
Tabbed Browser
Type:
defect

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
Future
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.15)

Attachments

(1 file, 1 obsolete file)

1803918-website_navigation-v1_1-25315.patch
1.21 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

STR:
Set View to enable Website Navigation Bar
Create HTML file with:
<link rel="linkme" href="https://www.seamonkey-project.org/">
Load the HTML file

Expected result
Website navigation bar shows an enabled "More" directory

Actual result
Website navigation bar shows a disabled "More" directory

Was working in 2.53.13 but stopped working in 2.53.14

[Approval Request Comment]
Regression caused by (bug #): various backports
User impact if declined: website navigation bar no longer works
Testing completed (on m-c, etc.): 2.53.16
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Code updated to the new way of checking for HTML node types.

Attachment #9306554 - Flags: review?(frgrahl)
Attachment #9306554 - Flags: approval-comm-release?
Attachment #9306554 - Flags: approval-comm-esr60?
Comment on attachment 9306554 [details] [diff] [review] 1803918-website_navigation-25316.patch > else if (currentNode instanceof Ci.nsIDOMElement) Surely any other references to `Ci.nsIDOMXXX` should be updated too?

(In reply to neil@parkwaycc.co.uk from comment #2)

Comment on attachment 9306554 [details] [diff] [review]
1803918-website_navigation-25316.patch

else if (currentNode instanceof Ci.nsIDOMElement)

Surely any other references to Ci.nsIDOMXXX should be updated too?

That would be dealt with when bug 1455674 and bug 1458174 land.

See Also: → 1458174, 1455674

Comment on attachment 9306554 [details] [diff] [review]
1803918-website_navigation-25316.patch

LGTM r/a=me

Attachment #9306554 - Flags: review?(frgrahl)
Attachment #9306554 - Flags: review+
Attachment #9306554 - Flags: approval-comm-release?
Attachment #9306554 - Flags: approval-comm-release+
Attachment #9306554 - Flags: approval-comm-esr60?
Attachment #9306554 - Flags: approval-comm-esr60+
Whiteboard: SM2.53.15

To go on top of patch 1406602-59a1

Attachment #9306554 - Attachment is obsolete: true
Attachment #9311228 - Flags: review?(frgrahl)
Attachment #9311228 - Flags: approval-comm-release?
Attachment #9311228 - Flags: approval-comm-esr60?

Comment on attachment 9311228 [details] [diff] [review]
1803918-website_navigation-v1_1-25315.patch

LGTM

Attachment #9311228 - Flags: review?(frgrahl)
Attachment #9311228 - Flags: review+
Attachment #9311228 - Flags: approval-comm-release?
Attachment #9311228 - Flags: approval-comm-release+
Attachment #9311228 - Flags: approval-comm-esr60?
Attachment #9311228 - Flags: approval-comm-esr60+
Depends on: 1406602

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/09cb10b3a953
Website Navigation Bar has stopped working. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/8d5f5c96e6153dcb3e93103715e4a1e036b7d3ec
Website Navigation Bar has stopped working. r=frg a=frg

status-seamonkey2.53: --- → fixed
tracking-seamonkey2.53: --- → +
Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: