1458351 - Checked format button invisible on macOS with dark theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

With dark theme on macOS the checked format buttons have a black text with semi transparent black background. This ends in a black hole on the format toolbar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: OSX-bg-color.patch

This is a little bit a hack as I can't give the button directly a light background colour because we use -moz-appearance: toolbarbutton. I have to underlay a layer with the background colour.

Unfortunately I can't take a screenshot with the active composer window to show the result. The problem is only with the active window. When it is inactive, the buttons are less transparent and readable again without patch.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8972433 [details] [diff] [review]
OSX-bg-color.patch

rs=jorgk.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/60c63f542e80
Add a background-color to the format buttons on Mac. rs=jorgk

Comment 4

[Jorg K (CEST = GMT+2)]

Beta (TB 60 beta 6):
https://hg.mozilla.org/releases/comm-beta/rev/ce49187468a02223fc7dfed5fda6796061ba9895

Once again, the patch didn't apply, I moved
  .tabmail-tab[selected="true"] {
down a bit to make it look like C-C.

Please check.