Closed Bug 1458351 Opened 7 years ago Closed 7 years ago

Checked format button invisible on macOS with dark theme

Categories

(Thunderbird :: Theme, enhancement)

All
macOS
enhancement
Not set
normal

Tracking

(thunderbird60 fixed, thunderbird61 fixed)

RESOLVED FIXED
Thunderbird 61.0
Tracking Status
thunderbird60 --- fixed
thunderbird61 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

With dark theme on macOS the checked format buttons have a black text with semi transparent black background. This ends in a black hole on the format toolbar.
This is a little bit a hack as I can't give the button directly a light background colour because we use -moz-appearance: toolbarbutton. I have to underlay a layer with the background colour. Unfortunately I can't take a screenshot with the active composer window to show the result. The problem is only with the active window. When it is inactive, the buttons are less transparent and readable again without patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8972433 - Flags: review?(jorgk)
Attachment #8972433 - Flags: approval-comm-beta?
Comment on attachment 8972433 [details] [diff] [review] OSX-bg-color.patch rs=jorgk.
Attachment #8972433 - Flags: review?(jorgk)
Attachment #8972433 - Flags: review+
Attachment #8972433 - Flags: approval-comm-beta?
Attachment #8972433 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/60c63f542e80 Add a background-color to the format buttons on Mac. rs=jorgk
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
Beta (TB 60 beta 6): https://hg.mozilla.org/releases/comm-beta/rev/ce49187468a02223fc7dfed5fda6796061ba9895 Once again, the patch didn't apply, I moved .tabmail-tab[selected="true"] { down a bit to make it look like C-C. Please check.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: