Closed
Bug 1458694
Opened 6 years ago
Closed 6 years ago
(android) ensure context menu works with ShadowDOM
Categories
(Firefox for Android Graveyard :: General, enhancement)
Firefox for Android Graveyard
General
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
1.60 KB,
patch
|
JanH
:
review+
|
Details | Diff | Splinter Review |
bug 1441647 is about desktop
Assignee | ||
Updated•6 years ago
|
Summary: ensure context menu works with ShadowDOM → (android) ensure context menu works with ShadowDOM
Assignee | ||
Comment 1•6 years ago
|
||
remote: View your change here: remote: https://hg.mozilla.org/try/rev/0baa2ff7460c37699dd93741ceef14a4bd968290 remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0baa2ff7460c37699dd93741ceef14a4bd968290 remote: recorded changegroup in replication log in 0.111s
Assignee: nobody → bugs
Assignee | ||
Comment 2•6 years ago
|
||
couldn't test that locally. trying with different package name remote: View your change here: remote: https://hg.mozilla.org/try/rev/2212e1c6f73ecb2827c650ddf33db6db15da528b remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2212e1c6f73ecb2827c650ddf33db6db15da528b remote: recorded changegroup in replication log in 0.109s
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8972909 [details] [diff] [review] wip I was told this works the expected way when http://mozilla.pettay.fi/moztests/shadow_link.html is used with shadow dom pref enabled.
Attachment #8972909 -
Flags: review?(bugmail)
Comment 4•6 years ago
|
||
Comment on attachment 8972909 [details] [diff] [review] wip Review of attachment 8972909 [details] [diff] [review]: ----------------------------------------------------------------- This seems fine to me, but I haven't touched fennec frontend code in a while so somebody who is more familiar with this code should review.
Attachment #8972909 -
Flags: review?(bugmail) → review?(jh+bugzilla)
Comment 5•6 years ago
|
||
Comment on attachment 8972909 [details] [diff] [review] wip Review of attachment 8972909 [details] [diff] [review]: ----------------------------------------------------------------- I'm not that much more familiar with the context menu handling code, but then I guess unfortunately no-one else really is at this point in time. I've looked through browser.js, though and those bits do indeed seem to be the only relevant places for contextmenu handling that could be affected.
Attachment #8972909 -
Flags: review?(jh+bugzilla) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4065e9400f2b (android) ensure context menu works with ShadowDOM, r=JanH
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4065e9400f2b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•