1458733 - React to Subdialog sizing change with a resize of the outer iframe

Status: NEW

(Firefox :: Settings UI, enhancement, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

As noted in bug 1457252 Subdialogs get sized once and any subsequent changes to their sizing is not reflected in the outer iframe sizing.

This makes the subdialogs prone to overflow and bugs related to race conditions.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Seems like a P3. Hey gandalf, since you were already hacking about in this area, were you thinking of picking this up?

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Okay, dear Sir. I get it. Last person to touch the code owns it...

But I must admit that the code in question [0] seems pretty... complicated. I don't think I understand it enough to know if there's a room for a major refactor or just hooking up an event into the existing code :(

MattN, Jaws, Gijs may have opinions on what should happen here. If it's just about hooking up an event I can do that, but I somehow suspect it is not.


[0] https://searchfox.org/mozilla-central/rev/c0d81882c7941c4ff13a50603e37095cdab0d1ea/browser/components/preferences/in-content/subdialogs.js#279-410

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Okay, dear Sir. I get it. Last person to touch the code owns it...
> 

Oh! No, that's not what I was trying to say here - it just seemed a little related to what you were doing elsewhere with subdialogs, so I thought it was, like, a follow-up bug or something for that work.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

That was a tongue-in-cheek reaction. I'm NI'ing people to get a better sense of what should be the scope of this refactor.

Comment 5

[:Gijs (he/him)]

I think you could hook up an 'overflow' event listener on the body / document element and have that re-trigger doing the size calculations. But that's a naive thought without actually trying it, so perhaps there are complications that make this difficult to do.

Comment 6

[Matthew N. [:MattN]]

What Gijs said seems reasonable… I also find some of the existing calculations a bit confusing btw.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Recently we have been using document.l10n.translateElements(document.querySelectorAll("[data-l10n-id]")).then(() => window.sizeToContent()) or similar code if sizeToContent is not applicable in the situation. I think that is what will have to be used here until we have a better solution.