1604782 - The bottom of the buttons "Cancel" and "Save" are cut in about:preferences#privacy -> "Add New Address"

Status: RESOLVED DUPLICATE of bug 1458733

(Toolkit :: Form Autofill, defect, P2)

Description

[Oana Botisan, Desktop QA]

Attachment: Screenshot_1.png

Affected versions

• Firefox 72.0b8
• Firefox 73.0a1

Affected platforms

• Windows 10 x64
• Windows 10 aarch x64
• Ubuntu 18.04 x64
• macOS 10.13

Prerequisites:

• Make sure the following preferences are correctly set:
  extensions.formautofill.available -> on
  extensions.formautofill.creditCards.available -> true
• A browser restart is required.

Steps to reproduce

1. Open Firefox and go to about:preferences#privacy -> "Add New Address".
2. From the "Country or Region" please select a country, eg: Canada.
3. Look at the "Cancel" and "Save" buttons.

Expected result

• The buttons are correctly displayed.

Actual result

• The bottom of the buttons are cut.

Regression range

• If this is a regression I will try to find it as soon as possible.

Additional notes

• Please look at the attached image.

Comment 1

[Negritas Sergiu, Desktop QA]

I have managed to find a regression for this issue, here is the pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b2d168294899bb4700cb3bd929c0bde85879fcea&tochange=06851b0adc9f3216b68177808ce0da19cd573fd9.

Comment 2

[Mike Taylor [:miketaylr]]

Kirk, can you take a look?

Comment 3

[Robin Steuber (she/her) [:bytesized]]

I'm afraid I cannot reproduce this issue. I've tried following the STR on Nightly and a local build on my Windows 10 machine, and the buttons look normal to me.

Comment 4

[Robin Steuber (she/her) [:bytesized]]

I'm concerned that no one seems to be fixing this. Could I get any more information on how to reproduce this? I believe I followed your STR exactly. I'm on Window 10, which you listed as being affected by this. I'm not sure what else to try.

Also, I'm fairly curious about the extensions.formautofill.creditCards.available preference. It shouldn't be necessary to open the "Add new address" window. Do you not experience the behavior without it? (I can't reproduce it either way)

I also notice that your "Country or Region" input extends a bit too far to the right, which I also can't reproduce or explain. I'm not sure what to think about that either.

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: macos-72.png

Matt, can you reproduce this? I was unable to on OSX 72 - here's what I see

Comment 6

[Oana Botisan, Desktop QA]

Attachment: add new address adjustment.gif

I tested again and I found out what the problem is. The Add New Address window doesn't automatically adjust to the size of the content. Please look at the attached gif to understand what I mean. I would like to mention that I didn't change the size of the window before making this gif.

Comment 7

[Matthew N. [:MattN]]

Looks like Oana can still reproduce in a new profile (or with XUL persistence data cleared).

Comment 8

[Robin Steuber (she/her) [:bytesized]]

Attachment: Add Address Overflow.png

I have finally reproduced this... sort of (see the attached screenshot). However, after reproducing this, I felt that it seemed suspiciously similar to a 2 year old bug that I am familiar with: Bug 1458733. I downloaded a version of Nightly from before Bug 1585482 merged, and indeed I could still reproduce the problem, suggesting that I was looking at Bug 1458733, not a regression of Bug 1585482.

So this has lead me to develop this theory:
I have fixed a good number of regressions resulting from Bug 1585482 recently. My theory is that I already fixed this problem, but that there is a similar pre-existing problem and that the two problems are getting mixed up.

Oana - Could you help me test this theory? Could you try to reproduce the problem that you see on an up-to-date Nightly with a version from before Bug 1585482 merged (I used this one)? Thanks!

Comment 9

[Oana Botisan, Desktop QA]

I apologize that I didn't reply sooner.
I used the build you provided in comment 8 on Windows 10 x64 and I can reproduce the issue on that build, but the difference is that on the build from 2019-11-01 there was a scrollbar present.
I've notice that on the latest Nightly 74.0a1 the scrollbar is displayed, too. Maybe some work was done on this part.

Comment 10

[Robin Steuber (she/her) [:bytesized]]

Alright, then it sounds to me like this bug is partially a duplicate of Bug 1458733, and partially a new bug, which was resolved by another patch that which I have not tracked down. I'm going to go ahead and mark it as a duplicate of Bug 1458733.