Closed Bug 1458814 Opened Last year Closed Last year

Make SMIL value setting not go through serialization and deserialization

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

This avoids the ComplexColor issues in bug 1457353, plus is faster, and makes more sense.
Assignee: nobody → emilio
Comment on attachment 8972940 [details]
Bug 1458814: Remove unused AnimationValue::mGecko.

https://reviewboard.mozilla.org/r/241502/#review247408
Attachment #8972940 - Flags: review?(hikezoe) → review+
Comment on attachment 8972941 [details]
Bug 1458814: Remove a bit of trivially dead code.

https://reviewboard.mozilla.org/r/241504/#review247410
Attachment #8972941 - Flags: review?(hikezoe) → review+
Comment on attachment 8972939 [details]
Bug 1458814: Make SMIL values not roundtrip through strings.

https://reviewboard.mozilla.org/r/241500/#review247414
Attachment #8972939 - Flags: review?(hikezoe) → review+
Comment on attachment 8972942 [details]
Bug 1458814: Remove code that is no longer called.

https://reviewboard.mozilla.org/r/241506/#review247416
Attachment #8972942 - Flags: review?(hikezoe) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9ac18a3eeaa5
Make SMIL values not roundtrip through strings. r=hiro
https://hg.mozilla.org/integration/autoland/rev/e7f7ea7ab4af
Remove unused AnimationValue::mGecko. r=hiro
https://hg.mozilla.org/integration/autoland/rev/c61d211a9f1d
Remove a bit of trivially dead code. r=hiro
https://hg.mozilla.org/integration/autoland/rev/d0990dff4fc4
Remove code that is no longer called. r=hiro
Backout by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5630f78d35cf
Backed out 4 changesets for failres in builds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/smil/style/anim-css-strokewidth-1-to-pct-pct.svg on a CLOSED TREE
Blocks: 1459418
The patches in this bug makes layout get more accurate values. That apparently
is confusing WebRender, which renders one more pixel height in some of the
rectangles.

I have no idea why, and I couldn't repro out of the reftest harness. I suspect
something something blob invalidation, but...
Flags: needinfo?(emilio)
Attachment #8973450 - Flags: review?(bugmail)
Comment on attachment 8973450 [details] [diff] [review]
Mark some tests as failing in WR.

Review of attachment 8973450 [details] [diff] [review]:
-----------------------------------------------------------------

The snapping for svg is in the midst of churn so this is fine for now.
Attachment #8973450 - Flags: review?(bugmail) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/218a57b6f00e
Make SMIL values not roundtrip through strings. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce36f98b0984
Remove unused AnimationValue::mGecko. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/94e44f6657b6
Remove a bit of trivially dead code. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e1b80eb24c7
Remove code that is no longer called. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6f3a0de1756
Mark some tests as failing with webrender. r=jrmuizel
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e7706b6ac82
followup: remove some unused imports. r=me
You need to log in before you can comment on or make changes to this bug.