1458814 - Make SMIL value setting not go through serialization and deserialization

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

This avoids the ComplexColor issues in bug 1457353, plus is faster, and makes more sense.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1458814: Make SMIL values not roundtrip through strings.

Review commit: https://reviewboard.mozilla.org/r/241500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241500/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1458814: Remove unused AnimationValue::mGecko.

Review commit: https://reviewboard.mozilla.org/r/241502/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241502/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1458814: Remove a bit of trivially dead code.

Review commit: https://reviewboard.mozilla.org/r/241504/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241504/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1458814: Remove code that is no longer called.

Au revoir!

Review commit: https://reviewboard.mozilla.org/r/241506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241506/

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8972940 [details]
Bug 1458814: Remove unused AnimationValue::mGecko.

https://reviewboard.mozilla.org/r/241502/#review247408

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8972941 [details]
Bug 1458814: Remove a bit of trivially dead code.

https://reviewboard.mozilla.org/r/241504/#review247410

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8972939 [details]
Bug 1458814: Make SMIL values not roundtrip through strings.

https://reviewboard.mozilla.org/r/241500/#review247414

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8972942 [details]
Bug 1458814: Remove code that is no longer called.

https://reviewboard.mozilla.org/r/241506/#review247416

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ac18a3eeaa5
Make SMIL values not roundtrip through strings. r=hiro
https://hg.mozilla.org/integration/autoland/rev/e7f7ea7ab4af
Remove unused AnimationValue::mGecko. r=hiro
https://hg.mozilla.org/integration/autoland/rev/c61d211a9f1d
Remove a bit of trivially dead code. r=hiro
https://hg.mozilla.org/integration/autoland/rev/d0990dff4fc4
Remove code that is no longer called. r=hiro

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5630f78d35cf
Backed out 4 changesets for failres in builds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/smil/style/anim-css-strokewidth-1-to-pct-pct.svg on a CLOSED TREE

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (bug 1458814) for failres in builds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/smil/style/anim-css-strokewidth-1-to-pct-pct.svg on a CLOSED TREE

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d0990dff4fc4eabd59b09cf6f9ff5c0e0f64fe9c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&selectedJob=176892352

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=176892352&repo=autoland&lineNumber=5635

Backout: https://hg.mozilla.org/integration/autoland/rev/5630f78d35cf0e4f7410ba08588ed055bdcc60bb

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Mark some tests as failing in WR.

The patches in this bug makes layout get more accurate values. That apparently
is confusing WebRender, which renders one more pixel height in some of the
rectangles.

I have no idea why, and I couldn't repro out of the reftest harness. I suspect
something something blob invalidation, but...

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8973450 [details] [diff] [review]
Mark some tests as failing in WR.

Review of attachment 8973450 [details] [diff] [review]:
-----------------------------------------------------------------

The snapping for svg is in the midst of churn so this is fine for now.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/218a57b6f00e
Make SMIL values not roundtrip through strings. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce36f98b0984
Remove unused AnimationValue::mGecko. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/94e44f6657b6
Remove a bit of trivially dead code. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e1b80eb24c7
Remove code that is no longer called. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6f3a0de1756
Mark some tests as failing with webrender. r=jrmuizel

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e7706b6ac82
followup: remove some unused imports. r=me

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/218a57b6f00e
https://hg.mozilla.org/mozilla-central/rev/ce36f98b0984
https://hg.mozilla.org/mozilla-central/rev/94e44f6657b6
https://hg.mozilla.org/mozilla-central/rev/8e1b80eb24c7
https://hg.mozilla.org/mozilla-central/rev/c6f3a0de1756
https://hg.mozilla.org/mozilla-central/rev/4e7706b6ac82