1458921 - regression: White vertical lines when scrolling text horizontally

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Attachment: 2018-05-03_16-58-06.mp4

Debian Testing, KDE, Xorg, Radeon RX480, 2560x1440 (Dell U2515H)

mozregression --good 2018-01-15 --bad 2018-04-01 --pref gfx.webrender.all:true general.autoScroll:true startup.homepage_welcome_url:'https://crash-stats.mozilla.com/report/index/b868a058-5274-4419-ac7c-a3a090180503#tab-metadata'
> 9:53.60 INFO: Last good revision: 73255f988eb133d3f515687cead96259d6fc0bb9
> 9:53.60 INFO: First bad revision: 94d10cf318b8f9c1b163a79afe978da9e47f01a8
> 9:53.60 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=73255f988eb133d3f515687cead96259d6fc0bb9&tochange=94d10cf318b8f9c1b163a79afe978da9e47f01a8

2018-02-09
> 94d10cf318b8	Lee Salzman — Bug 1396637 - disable WR subpixel positioning with FreeType. r=jrmuizel

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: use new WR subpixel positioning API

This just uses the new API introduced by https://github.com/servo/webrender/pull/2738

Or rather, the API for it has changed, and this patch is necessary to keep things working.

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: use new WR subpixel positioning API. r=gankro

Needed to add a bit of fuzz to make this work.

Comment 3

[Lee Salzman [:lsalzman]]

WR PR 2738 got merged, so this patch will be necessary when we import it in a WR update.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f163bdabcdb0b687c5aac65ff36f46f34102a4a

Please update the patch to address the macOS reftest failures/passes.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(Also please rebase it to m-c tip)

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: use new WR subpixel positioning API. r=gankro

Rebased and added more fuzz.

Comment 7

[Lee Salzman [:lsalzman]]

Attachment: use new WR subpixel positioning API. r=gankro

Fix some Windows fuzz ordering.

Comment 8

[Lee Salzman [:lsalzman]]

Attachment: use new WR subpixel positioning API. r=gankro

One last Mac fuzz fix.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

FYI in the first patch you had removed the fuzzy-if for windows on 1193519-sideways-lr-decoration-1-ref.html but at some point you put that back in. Still need that removed though. I'll make that change in the version of the patch that I'll put on bug 1463416.