Closed Bug 1458956 Opened 6 years ago Closed 6 years ago

Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode

Categories

(Firefox :: Theme, defect, P1)

All
Windows
defect

Tracking

()

VERIFIED FIXED
Firefox 61
Tracking Status
relnote-firefox --- 60+
firefox-esr52 --- unaffected
firefox-esr60 --- verified
firefox59 --- unaffected
firefox60 --- verified
firefox61 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: access, regression)

Attachments

(1 file)

      No description provided.
Comment on attachment 8972945 [details]
Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

https://reviewboard.mozilla.org/r/241510/#review247346

Thanks for splitting this out!
Attachment #8972945 - Flags: review?(mconley) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7efdfb3decd
Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode. r=mconley
Blocks: 1419152
Comment on attachment 8972945 [details]
Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1442651
[User impact if declined]: We're regressing bug 1419152. That's an a11y regression.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: see bug 1419152 comment 0
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix for CSS selector
[String changes made/needed]: /
Attachment #8972945 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/b7efdfb3decd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment on attachment 8972945 [details]
Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

60 is on release now.
Attachment #8972945 - Flags: approval-mozilla-release?
Attachment #8972945 - Flags: approval-mozilla-esr60?
Attachment #8972945 - Flags: approval-mozilla-beta?
Flags: qe-verify+
I have reproduced this issue following steps from bug 1419152 comment 0, using Firefox  59.0a1 (2017.11.20) on Win 10 x64.
I did exploratory testing around opening new tabs with High Contrast Black settings on Windows 10 x64 and Win 7 x64 using Firefox 61.0b3, I didn't found any issues. 
Note: When change the system settings and in meantime Firefox is open, have to restart Firefox to apply the settings.
Flags: qe-verify+
Status: RESOLVED → VERIFIED
Comment on attachment 8972945 [details]
Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

a11y regression with simple css fix, approved for 60.0.1
Attachment #8972945 - Flags: approval-mozilla-release?
Attachment #8972945 - Flags: approval-mozilla-release+
Attachment #8972945 - Flags: approval-mozilla-esr60?
Attachment #8972945 - Flags: approval-mozilla-esr60+
Added this to Firefox and ESR 60.0.1 release notes
Flags: qe-verify+
I can confirm this issue is fixed, I verified using Firefox 60.0.1 and 60.0.1esr, on Windows 10 x64, Windows 7 x64 and Windows 8.1 x64.
You need to log in before you can comment on or make changes to this bug.