1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

Review commit: https://reviewboard.mozilla.org/r/241510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241510/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8972945 [details]
Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

https://reviewboard.mozilla.org/r/241510/#review247346

Thanks for splitting this out!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7efdfb3decd
Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode. r=mconley

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8972945 [details]
Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1442651
[User impact if declined]: We're regressing bug 1419152. That's an a11y regression.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: see bug 1419152 comment 0
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix for CSS selector
[String changes made/needed]: /

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b7efdfb3decd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8972945 [details]
Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

60 is on release now.

Comment 7

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue following steps from bug 1419152 comment 0, using Firefox  59.0a1 (2017.11.20) on Win 10 x64.
I did exploratory testing around opening new tabs with High Contrast Black settings on Windows 10 x64 and Win 7 x64 using Firefox 61.0b3, I didn't found any issues. 
Note: When change the system settings and in meantime Firefox is open, have to restart Firefox to apply the settings.

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8972945 [details]
Bug 1458956 - Fix selectors for tabbrowser to use -moz-default-background-color as its default background in high contrast mode.

a11y regression with simple css fix, approved for 60.0.1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/b7e489ec7f45

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/d5595a55f4c1

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added this to Firefox and ESR 60.0.1 release notes

Comment 13

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 60.0.1 and 60.0.1esr, on Windows 10 x64, Windows 7 x64 and Windows 8.1 x64.