Open Bug 1459064 Opened 6 years ago Updated 2 years ago

Incorrect suggested "Save Page As" file name for XSLT files

Categories

(Firefox :: File Handling, defect, P3)

61 Branch
All
Windows 10
defect

Tracking

()

Tracking Status
firefox62 --- affected

People

(Reporter: felix.bau, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180503100146

Steps to reproduce:

I opened ftp://ftp.fu-berlin.de/doc/rfc/authors/rfc2629.xslt and used save page.
Once on the "page" (I did another bug report for that: https://bugzilla.mozilla.org/show_bug.cgi?id=1459057 ) and once in view-source.


Actual results:

The file name for the page was:
"(xsl apply-templates select='front_title' mode='get-text-content' _).txt"
The file name on the view-source page was:
"ftp _ftp.fu-berlin.de_doc_rfc_authors_rfc2629.xslt.html"


Expected results:

Since it's ftp, the original file-name should be used.
Especially since it's not an html file with a title attribute, but a stylesheet.

Another example:
Doing the same for ftp://ftp.fu-berlin.de/doc/rfc/authors/rfc3659-diff.html results in Firefox trying to save it as .txt instead of .html :/ (and it doesn't use the original file name, but at least the existing title attribute of the page)
I just realized, that the file type drop down (save dialog on Windows) just remembers the last choice, so that part of this report might just work as desired, but there might be a better way to select file names in these cases, I think.
Hi!

Reproduced on Win10 Nightly 62.0a1 Build ID: 20180508100105

(In reply to Djfe from comment #1)
> I just realized, that the file type drop down (save dialog on Windows) just
> remembers the last choice, so that part of this report might just work as
> desired, but there might be a better way to select file names in these
> cases, I think.
This works as expected.

This issue seems to be on the same subject as Bug 254139. However, since the bug 254139 seems to be closed I am wondering if there isn't value to the idea of having the "save as" default behind a preference, rather than the current default behavior: using the title attribute. 
Chris would you please take a look at this? 

Thank you!
Blocks: 254139
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Component: Untriaged → File Handling
Ever confirmed: true
Flags: needinfo?(cpeterson)
OS: Unspecified → Windows 10
Hardware: Unspecified → x86
We don't need a new preference for this, however the default choice for this XSLT file looks like a bug that can be fixed.
Priority: -- → P3
Summary: "save page" for some files results in inaccurate file names/extensions → Incorrect suggested "Save Page As" file name for XSLT files
Thanks. I can reproduce this bug.
Flags: needinfo?(cpeterson)
Hardware: x86 → All
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.