Rename ServoCSSParsingEnvironment and related functions to ParsingEnvironment.

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emilio, Assigned: bobslept, Mentored)

Tracking

({good-first-bug})

unspecified
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Servo is the only style system now, so no point in explicitly mention it.
Priority: -- → P3
(Assignee)

Comment 1

a year ago
Alright I hope this patch is correct. I have renamed ServoCSSParsingEnvironment to ParsingEnvironment, including some related functions. It builds and runs alright. Also passing |./mach mochitest -f browser layout/style/test/|.
(Reporter)

Comment 2

a year ago
Patch looks great, thank you! You need to request someone for review (I can be that someone if you want), using the r? flag in the "details" section of the attachment.

Meanwhile, I've pushed it to our CI in https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8b0cd0ac142bf0d29a233d0b0ea77cd005d5c7b.

Thanks for the patch!
(Assignee)

Updated

a year ago
Attachment #8975530 - Flags: review?(emilio)
(Reporter)

Updated

a year ago
Assignee: nobody → bobslept
(Reporter)

Comment 3

a year ago
Comment on attachment 8975530 [details] [diff] [review]
1459111-rename-servocssparsingenvironment.patch

Review of attachment 8975530 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks great to me!

Since you presumably don't have commit access yet you need to either put the checkin-needed keyword on the bug, or I can push it for you, whatever you prefer.
Attachment #8975530 - Flags: review?(emilio) → review+
(Assignee)

Comment 4

a year ago
Great work. You are right on the commit access part. Please push that beauty for me.

Comment 5

a year ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c258f15c012
Rename ServoCSSParsingEnvironment to ParsingEnvironment. r=emilio

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5c258f15c012
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.