Closed Bug 1459111 Opened 6 years ago Closed 5 years ago

Rename ServoCSSParsingEnvironment and related functions to ParsingEnvironment.

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: emilio, Assigned: bobslept, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

1459111-rename-servocssparsingenvironment.patch
10.68 KB, patch
emilio
: review+
Details | Diff | Splinter Review 
Servo is the only style system now, so no point in explicitly mention it.
Priority: -- → P3
Alright I hope this patch is correct. I have renamed ServoCSSParsingEnvironment to ParsingEnvironment, including some related functions. It builds and runs alright. Also passing |./mach mochitest -f browser layout/style/test/|.
Patch looks great, thank you! You need to request someone for review (I can be that someone if you want), using the r? flag in the "details" section of the attachment.

Meanwhile, I've pushed it to our CI in https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8b0cd0ac142bf0d29a233d0b0ea77cd005d5c7b.

Thanks for the patch!
Attachment #8975530 - Flags: review?(emilio)
Assignee: nobody → bobslept
Comment on attachment 8975530 [details] [diff] [review]
1459111-rename-servocssparsingenvironment.patch

Review of attachment 8975530 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks great to me!

Since you presumably don't have commit access yet you need to either put the checkin-needed keyword on the bug, or I can push it for you, whatever you prefer.
Attachment #8975530 - Flags: review?(emilio) → review+
Great work. You are right on the commit access part. Please push that beauty for me.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c258f15c012
Rename ServoCSSParsingEnvironment to ParsingEnvironment. r=emilio
https://hg.mozilla.org/mozilla-central/rev/5c258f15c012
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.