1459183 - single character not highlighted in bold as matching anymore

Status: NEW

(Tree Management :: Treeherder, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Single characters in the bug summaries of suggested failures are not highlighted in bold anymore as matching even if they match the actual failure line. First noticed this on Monday, but it can get annoying e.g. when it comes to numbers/offsets and coordinates like bug 1448497 and one has to pay closely attention.

Example: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=aa5c4afe0acb45067fe6985bd94f407138f323e0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=176639112

Comment 1

[Cameron Dawson [:camd]]

Yeah, this was a compromise I made with our new matching package that generates safer HTML.  I excluded single characters because the package was matching things like:

"This is a string to match"

On a string like this:

"We have apples"

produced bolding like (markdown style):

We h**a**ve **a**pples

But I think I could create a custom ``findChunks`` function for that component that would only match full words, but still split on parts of paths.  I will put this in my backlog and try to address it soon.

Comment 2

[Cameron Dawson [:camd]]

This would be good to get done. But I'm not going to get to it anytime soon.