Closed
Bug 1459363
Opened 7 years ago
Closed 7 years ago
Remove unused NS_COLOR_* macros
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: erahm, Assigned: KrisWright, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
The |NS_COLOR_*| macros in nsStyleConsts.h [1] are unused and can be removed.
[1] https://searchfox.org/mozilla-central/rev/53afcfdbabed96883126d0ebbcac499b358e32f2/layout/style/nsStyleConsts.h#235-247
|
||
Comment 1•7 years ago
|
||
They probably became unused after bug 1457802.
|
||
Updated•7 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 2•7 years ago
|
||
Hi! I'd like to work on this. Can you assign it to me?
Flags: needinfo?(erahm)
|
Reporter | |
Comment 3•7 years ago
|
||
Sure thing! Let me know if you have any questions on how to get started.
Assignee: nobody → kwright
Flags: needinfo?(erahm)
|
|
Reporter | |
Updated•7 years ago
|
Keywords: good-first-bug
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8973841 [details]
Bug 1459363 - Remove unused NS_COLOR_* macros.
https://reviewboard.mozilla.org/r/242212/#review248046
Looks good, thanks for the patch! r=me
Attachment #8973841 -
Flags: review?(erahm) → review+
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4b49a0d00b3
Remove unused NS_COLOR_* macros. r=erahm
|
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•