Remove unused NS_COLOR_* macros

RESOLVED FIXED in Firefox 62

Status

()

P3
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: erahm, Assigned: KrisWright, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

unspecified
mozilla62
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
The |NS_COLOR_*| macros in nsStyleConsts.h [1] are unused and can be removed.

[1] https://searchfox.org/mozilla-central/rev/53afcfdbabed96883126d0ebbcac499b358e32f2/layout/style/nsStyleConsts.h#235-247
They probably became unused after bug 1457802.
Priority: -- → P3
(Assignee)

Comment 2

11 months ago
Hi! I'd like to work on this. Can you assign it to me?
Flags: needinfo?(erahm)
(Reporter)

Comment 3

11 months ago
Sure thing! Let me know if you have any questions on how to get started.
Assignee: nobody → kwright
Flags: needinfo?(erahm)
(Reporter)

Updated

11 months ago
Keywords: good-first-bug
Comment hidden (mozreview-request)
(Reporter)

Comment 5

11 months ago
mozreview-review
Comment on attachment 8973841 [details]
Bug 1459363 - Remove unused NS_COLOR_* macros.

https://reviewboard.mozilla.org/r/242212/#review248046

Looks good, thanks for the patch! r=me
Attachment #8973841 - Flags: review?(erahm) → review+

Comment 6

11 months ago
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4b49a0d00b3
Remove unused NS_COLOR_* macros. r=erahm

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d4b49a0d00b3
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.