1459590 - (Android) Check that things handled by SelectHelper.jsm (<select> elements etc.) work with ShadowDOM

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jan Henning [:JanH]]

https://dxr.mozilla.org/mozilla-central/rev/1b257ee52e90bc51d36006ec081e3d4a0ead5640/mobile/android/modules/SelectHelper.jsm,
plus I think the equivalent in GeckoView might be around
https://dxr.mozilla.org/mozilla-central/rev/1b257ee52e90bc51d36006ec081e3d4a0ead5640/mobile/android/components/geckoview/GeckoViewPrompt.js#48 ?

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

This is one of the few blockers shipping Shadow DOM, so if anyone could take a look at this, great.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I assume event.composedTarget would be useful here.

Comment 3

[Edgar Chen [:edgar]]

Attachment: Test <select> element in shadow dom

Test case for <select> element in shadow dom. Fennec doesn't show the select menu while clicking the <select> element inside the shadow dom.

Comment 4

[Edgar Chen [:edgar]]

(In reply to Olli Pettay [:smaug] (vacation Jul 15->) from comment #2)
> I assume event.composedTarget would be useful here.

Yeah, using event.composedTarget fixes the issue in Fennec.

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1459590 - Ensure Fennec select and input element work with ShadowDom;

Comment 6

[Edgar Chen [:edgar]]

Attachment: shadow_datetime.html

I found DateTime input type has a similar issue with ShadowDom. Here is the test script.

Comment 7

[Edgar Chen [:edgar]]

Attachment: Bug 1459590 - Ensure GeckoView select and input element work with ShadowDom;

Comment 8

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4572e13bf686c447f67843109d7e8da51fcf337

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

(apparently snorp is on pto)

Comment 10

[Phabricator Automation]

Comment on attachment 8992289 [details]
Bug 1459590 - Ensure Fennec select and input element work with ShadowDom;

Jim Chen [:jchen] [:darchons] has approved the revision.

https://phabricator.services.mozilla.com/D2151

Comment 11

[Phabricator Automation]

Comment on attachment 8992294 [details]
Bug 1459590 - Ensure GeckoView select and input element work with ShadowDom;

Jim Chen [:jchen] [:darchons] has approved the revision.

https://phabricator.services.mozilla.com/D2153

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bbf774e9e48
Ensure Fennec select and input element work with ShadowDom; r=jchen

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3de5d538b2d4
Ensure GeckoView select and input element work with ShadowDom; r=jchen

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3bbf774e9e48

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3de5d538b2d4