Closed Bug 1460022 Opened 7 years ago Closed 7 years ago

Investigate using one-time initialization to prevent multiple attempts of hooking the same function

Categories

(Core :: General, enhancement, P1)

Product:
Core
Component:
General
Platform:
Unspecified
Windows
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

(Whiteboard: inj+ [overhead:0k])

Attachments

(13 files, 1 obsolete file)

Part 1 - Modify DLL interceptor to use one-time initialization
7.68 KB, patch
handyman
: review+
Details | Diff | Splinter Review
Part 2 - Update TestDllInterceptor
39.04 KB, patch
handyman
: review+
Details | Diff | Splinter Review
Part 3 - Update TestDllInterceptorCrossProcess
1.95 KB, patch
handyman
: review+
Details | Diff | Splinter Review
Part 4 - Update a11y
2.35 KB, patch
Jamie
: review+
Details | Diff | Splinter Review
Part 5 - Update launcher process
2.08 KB, patch
molly
: review+
Details | Diff | Splinter Review
Part 6 - Update GMP
1.95 KB, patch
cpearce
: review+
Details | Diff | Splinter Review
Part 7 - Update plugins
19.67 KB, patch
handyman
: review+
Details | Diff | Splinter Review
Part 8 - Update DLL blocklist
3.99 KB, patch
molly
: review+
Details | Diff | Splinter Review
Part 9 - Update sandbox
2.67 KB, patch
bobowen
: review+
Details | Diff | Splinter Review
Part 10 - Update crashreporter
2.54 KB, patch
away
: review+
Details | Diff | Splinter Review
Part 11 - Update nsWindow
6.20 KB, patch
molly
: review+
Details | Diff | Splinter Review
Part 12 - Update XPCOM
7.76 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
Part 13 - Update profiler
3.11 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review
The idea here is that maybe we could require an INIT_ONCE cookie that forces callers to do the right thing with respect to AddHook.
Component: General → Networking
Aaron, is this a Networking bug? Can you explain what's involved here?
Flags: needinfo?(aklotz)
No, this is not a networking bug. This is Windows-specific code used for function hooking.
Flags: needinfo?(aklotz)
Component: Networking → General
status-firefox61: --- → affected
Priority: -- → P1
Whiteboard: inj+
Aaron do you have a guess as to how much overhead this is? We're guessing < 10k.
Whiteboard: inj+ → inj+ [overhead:10k]
Zero at the moment; this bug will prevent future problems, but all of the individual occurrences have already been fixed in other bugs.
Whiteboard: inj+ [overhead:10k] → inj+ [overhead:0k]
Attachment #8988321 - Flags: review?(davidp99)
Attached patch Part 4 - Update a11y — — Splinter Review
Attachment #8988323 - Flags: review?(jteh)
Attached patch Part 4 - Update launcher process (obsolete) — — Splinter Review
Attachment #8988324 - Flags: review?(mhowell)
Attachment #8988324 - Attachment is obsolete: true
Attachment #8988324 - Flags: review?(mhowell)
Attachment #8988325 - Flags: review?(mhowell)
Attached patch Part 6 - Update GMP — — Splinter Review
Attachment #8988326 - Flags: review?(cpearce)
Attached patch Part 7 - Update plugins — — Splinter Review
Attachment #8988327 - Flags: review?(davidp99)
Attached patch Part 8 - Update DLL blocklist — — Splinter Review
Attachment #8988328 - Flags: review?(mhowell)
Attached patch Part 9 - Update sandbox — — Splinter Review
Attachment #8988329 - Flags: review?(bobowencode)
Attached patch Part 10 - Update crashreporter — — Splinter Review
Attachment #8988330 - Flags: review?(dmajor)
Attached patch Part 11 - Update nsWindow — — Splinter Review
Attachment #8988331 - Flags: review?(mhowell)
Attached patch Part 12 - Update XPCOM — — Splinter Review
Attachment #8988332 - Flags: review?(nfroyd)
Attached patch Part 13 - Update profiler — — Splinter Review
Attachment #8988333 - Flags: review?(n.nethercote)
Note that, in these patches, I have removed any redundant code that ensures one-time initialization, since that is now built-in.
Comment on attachment 8988333 [details] [diff] [review] Part 13 - Update profiler Review of attachment 8988333 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8988333 - Flags: review?(n.nethercote) → review+
Attachment #8988326 - Flags: review?(cpearce) → review+
Attachment #8988323 - Flags: review?(jteh) → review+
Attachment #8988329 - Flags: review?(bobowencode) → review+
Attachment #8988325 - Flags: review?(mhowell) → review+
Attachment #8988328 - Flags: review?(mhowell) → review+
Attachment #8988331 - Flags: review?(mhowell) → review+
Comment on attachment 8988320 [details] [diff] [review] Part 1 - Modify DLL interceptor to use one-time initialization Review of attachment 8988320 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozglue/misc/nsWindowsDllInterceptor.h @@ +12,5 @@ > #include "mozilla/ArrayUtils.h" > #include "mozilla/CheckedInt.h" > #include "mozilla/DebugOnly.h" > +#include "mozilla/Move.h" > +#include "mozilla/Tuple.h" Very minor nit -- I might be missing something but I don't think you use these here (including Attributes.h above). It looks like Tuple is used in the TestDllInterceptor (but that file builds without that include so maybe its transitively included) but Move isn't needed at all.
Attachment #8988320 - Flags: review?(davidp99) → review+
Attachment #8988322 - Flags: review?(davidp99) → review+
Comment on attachment 8988332 [details] [diff] [review] Part 12 - Update XPCOM Review of attachment 8988332 [details] [diff] [review]: ----------------------------------------------------------------- This seems pretty nice. Have you tried to see whether your code avoids static initializers for these new global variables? We count static constructors for Windows builds, so you should be able to see these statistics on try.
Attachment #8988332 - Flags: review?(nfroyd) → review+
Attachment #8988327 - Flags: review?(davidp99) → review+
Comment on attachment 8988321 [details] [diff] [review] Part 2 - Update TestDllInterceptor Review of attachment 8988321 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for doing this! I considered it when I suped up the test a while back but it was easier to just cut and paste for test code. This is much less sketchy. ::: mozglue/tests/interceptor/TestDllInterceptor.cpp @@ -578,5 @@ > - SCHANNEL_CRED cred; > - memset(&cred, 0, sizeof(cred)); > - cred.dwVersion = SCHANNEL_CRED_VERSION; > - return patchedAcquireCredentialsHandleA(0, UNISP_NAME, SECPKG_CRED_OUTBOUND, > - 0, &cred, 0, 0, &sCredHandle, 0) == S_OK; [...] @@ +534,2 @@ > > + TEST_HOOK(sspicli.dll, AcquireCredentialsHandleA, NotEquals, SEC_E_OK) && I noticed that you changed the meaning of a few of the methods that had somewhat complicated handlers (like AcquireCredentialsHandleA). This is fine in the cases I noticed but I didn't go through the huge list of old methods and confirm they are aligned -- I'm trusting that in passing and not crashing, the test confirms its own validity.
Attachment #8988321 - Flags: review?(davidp99) → review+
Attachment #8988330 - Flags: review?(dmajor) → review+
(In reply to David Parks (dparks) [:handyman] from comment #22) > Comment on attachment 8988320 [details] [diff] [review] > Part 1 - Modify DLL interceptor to use one-time initialization > > Review of attachment 8988320 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mozglue/misc/nsWindowsDllInterceptor.h > @@ +12,5 @@ > > #include "mozilla/ArrayUtils.h" > > #include "mozilla/CheckedInt.h" > > #include "mozilla/DebugOnly.h" > > +#include "mozilla/Move.h" > > +#include "mozilla/Tuple.h" > > Very minor nit -- I might be missing something but I don't think you use > these here (including Attributes.h above). It looks like Tuple is used in > the TestDllInterceptor (but that file builds without that include so maybe > its transitively included) but Move isn't needed at all. I think that some of these might be used by the interceptor/* headers. Probably the best solution is to audit those and move that stuff around as appropriate. I think this is complicated enough to warrant a follow-up bug.
(In reply to Nathan Froyd [:froydnj] from comment #23) > Comment on attachment 8988332 [details] [diff] [review] > Part 12 - Update XPCOM > > Review of attachment 8988332 [details] [diff] [review]: > ----------------------------------------------------------------- > > This seems pretty nice. Have you tried to see whether your code avoids > static initializers for these new global variables? We count static > constructors for Windows builds, so you should be able to see these > statistics on try. It shouldn't, but I'll verify before pushing.
Yep, looks good.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cd5f9b4a6af952a3831281c27abe0b5aaa466c8 Bug 1460022: Part 1 - Modify DLL interceptor to use one-time initialization when setting hooks; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/0ddf581bdaac15f280673e3937c283cd65cc70a7 Bug 1460022: Part 2 - Update TestDllInterceptor to use new DLL interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/8bb5142d3f530f898f48105ef08e2d9eadd48577 Bug 1460022: Part 3 - Update TestDllInterceptorCrossProcess to reflect new interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/09da660071e1705e6bebae64134af3d63b32d212 Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie https://hg.mozilla.org/integration/mozilla-inbound/rev/933e0b698f8e8efb7706702e8c3565ba6449406e Bug 1460022: Part 5 - Update launcher process to work with new DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/867a1351efffcc0a3b4cab364e518d8f4d5d5983 Bug 1460022: Part 6 - Update GMP code to work with new DLL interceptor interface; r=cpearce https://hg.mozilla.org/integration/mozilla-inbound/rev/18f8f85c03076707495a7e55929eba3bd3164214 Bug 1460022: Part 7 - Update plugin code to work with revised DLL interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/9cb0b7a1540255ca017c45eae89b227d9ed29ba1 Bug 1460022: Part 8 - Update DLL blocklist to work with revised DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/221137d1c2de7988bfcb63deb258737fe8fb29ce Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen https://hg.mozilla.org/integration/mozilla-inbound/rev/02a7ed68933f925927b7037d3532f1128e5a6527 Bug 1460022: Part 10 - Update crash reporter to work with revised DLL interceptor interface; r=dmajor https://hg.mozilla.org/integration/mozilla-inbound/rev/2df129bd56925466d6024d22b493037c6436e63c Bug 1460022: Part 11 - Update Win32 nsWindow to work with revised DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/18fbfa7ca68556a5fb6de2c85eab23e796bb1ce8 Bug 1460022: Part 12 - Update XPCOM to use revised DLL interceptor interface; r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/0734142a3f358117ac8baddd994dc5526d124593 Bug 1460022: Part 13 - Update profiler to use revised DLL interceptor interface; r=njn
Backed out 13 changesets (bug 1460022) for bustages in builds/worker/workspace/build/src/dom/plugins/ipc/FunctionHook.h:100:24 on a CLOSED TREE Problematic push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=0734142a3f358117ac8baddd994dc5526d124593&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=186318884 Log: https://treeherder.mozilla.org/logviewer.html#?job_id=186318884&repo=mozilla-inbound&lineNumber=21818 Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3a415f165864dc3c17ea1e49d66d34245d660fd4&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified [task 2018-07-03T23:45:44.798Z] 23:45:44 INFO - /builds/worker/workspace/build/src/dom/plugins/ipc/FunctionHook.h:100:24: error: use of undeclared identifier 'WindowsDllInterceptor' [task 2018-07-03T23:45:44.798Z] 23:45:44 INFO - using FuncHookType = WindowsDllInterceptor::FuncHookType<FunctionType*>; [task 2018-07-03T23:45:44.798Z] 23:45:44 INFO - ^ [task 2018-07-03T23:45:44.798Z] 23:45:44 INFO - /builds/worker/workspace/build/src/dom/plugins/ipc/FunctionHook.h:138:3: error: unknown type name 'FuncHookType'; did you mean 'FunctionType'? [task 2018-07-03T23:45:44.798Z] 23:45:44 INFO - FuncHookType mStub; [task 2018-07-03T23:45:44.798Z] 23:45:44 INFO - ^~~~~~~~~~~~ [task 2018-07-03T23:45:44.798Z] 23:45:44 INFO - FunctionType [task 2018-07-03T23:45:44.798Z] 23:45:44 INFO - /builds/worker/workspace/build/src/dom/plugins/ipc/FunctionHook.h:97:46: note: 'FunctionType' declared here [task 2018-07-03T23:45:44.800Z] 23:45:44 INFO - template<FunctionHookId functionId, typename FunctionType> [task 2018-07-03T23:45:44.800Z] 23:45:44 INFO - ^ [task 2018-07-03T23:45:44.800Z] 23:45:44 INFO - 2 errors generated. [task 2018-07-03T23:45:44.800Z] 23:45:44 INFO - /builds/worker/workspace/build/src/config/rules.mk:1032: recipe for target 'Unified_cpp_dom_plugins_ipc0.o' failed [task 2018-07-03T23:45:44.800Z] 23:45:44 INFO - make[4]: *** [Unified_cpp_dom_plugins_ipc0.o] Error 1 [task 2018-07-03T23:45:44.800Z] 23:45:44 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/plugins/ipc' [task 2018-07-03T23:45:44.801Z] 23:45:44 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'dom/plugins/ipc/target' failed [task 2018-07-03T23:45:44.801Z] 23:45:44 INFO - make[3]: *** [dom/plugins/ipc/target] Error 2 [task 2018-07-03T23:45:44.801Z] 23:45:44 INFO - make[3]: *** Waiting for unfinished jobs....
Flags: needinfo?(aklotz)
https://hg.mozilla.org/integration/mozilla-inbound/rev/15822d9848d8647ef9a143f4b718d8d5d66a4c0a Bug 1460022: Part 1 - Modify DLL interceptor to use one-time initialization when setting hooks; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/b8e8aea4a01f596dc543216fa946ac0170b4d616 Bug 1460022: Part 2 - Update TestDllInterceptor to use new DLL interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/00b20c0a763741ef161ecc48794d28b1db97cbe9 Bug 1460022: Part 3 - Update TestDllInterceptorCrossProcess to reflect new interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/34aa7c29b31e7fa888e8ef1c7ae8c78806c945d3 Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie https://hg.mozilla.org/integration/mozilla-inbound/rev/69eacc5c3ab87fdeb2a91e7ee00bf2bc5ef2bde5 Bug 1460022: Part 5 - Update launcher process to work with new DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/a16486a6f685099ef25a1bde3aa63ee5eb66f42a Bug 1460022: Part 6 - Update GMP code to work with new DLL interceptor interface; r=cpearce https://hg.mozilla.org/integration/mozilla-inbound/rev/5f3dfde41e384ad6374a22cdd5d4964bd0602491 Bug 1460022: Part 7 - Update plugin code to work with revised DLL interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a036b976e65d417fa571788e7dd111038d2c4c Bug 1460022: Part 8 - Update DLL blocklist to work with revised DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/be7032cddad2709068fb4606e10167697ba1944d Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen https://hg.mozilla.org/integration/mozilla-inbound/rev/91fed649dd5a3f6c3dc48ca69711560851553a50 Bug 1460022: Part 10 - Update crash reporter to work with revised DLL interceptor interface; r=dmajor https://hg.mozilla.org/integration/mozilla-inbound/rev/ecb1b6fd3134ad8336338cdff1d231fc24015ee9 Bug 1460022: Part 11 - Update Win32 nsWindow to work with revised DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/c3b3b854affd7efdae5631ed024d19900b90a501 Bug 1460022: Part 12 - Update XPCOM to use revised DLL interceptor interface; r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/b798c3689bbf11e6d16844df3c79a6b15c8622cc Bug 1460022: Part 13 - Update profiler to use revised DLL interceptor interface; r=njn
Flags: needinfo?(aklotz)
Backed out 13 changesets (bug 1460022) for bustages in :/build/build/src/mozglue/tests/interceptor/TestDllInterceptor.cpp(113) on a CLOSED TREE Problematic push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b798c3689bbf11e6d16844df3c79a6b15c8622cc&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=186320731 Log: https://treeherder.mozilla.org/logviewer.html#?job_id=186320731&repo=mozilla-inbound&lineNumber=34652 Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9cfc3fe9fe3832f29ebcba0318db8ee21f926db2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified 00:32:40 INFO - z:/build/build/src/config/rules.mk:1032: recipe for target 'TestDllInterceptor.obj' failed 00:32:40 INFO - mozmake.EXE[4]: *** [TestDllInterceptor.obj] Error 2 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/mozglue/tests/interceptor' 00:32:40 INFO - mozmake.EXE[4]: *** Waiting for unfinished jobs.... 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/accessible/interfaces/ia2' 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/accessible/interfaces/ia2' 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/mfbt/tests' 00:32:40 INFO - TestJSONWriter.exe 00:32:40 INFO - z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x64/link.exe -nologo -out:TestJSONWriter.exe -pdb:TestJSONWriter.pdb @z:/build/build/src/obj-firefox/mfbt/tests/TestJSONWriter_exe.list -SUBSYSTEM:CONSOLE,6.01 -STACK:2097152 -LARGEADDRESSAWARE -NXCOMPAT -RELEASE -DYNAMICBASE -DEBUG -DEBUGTYPE:CV kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib 00:32:40 INFO - Creating library TestJSONWriter.lib and object TestJSONWriter.exp 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/mfbt/tests' 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/security/nss/lib/freebl/freebl_freebl3' 00:32:40 INFO - z:/build/build/src/sccache2/sccache.exe z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x64/cl.exe -Fodesblapi.obj -c -DDEBUG '-DSHLIB_SUFFIX="dll"' '-DSHLIB_PREFIX=""' '-DSHLIB_VERSION="3"' '-DSOFTOKEN_SHLIB_VERSION="3"' -DRIJNDAEL_INCLUDE_TABLES -DMP_API_COMPATIBLE -DKRML_NOUINT128 -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DSEED_ONLY_DEV_URANDOM -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -D_WINDOWS -DWIN95 -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -DNSS_DISABLE_LIBPKIX -DMP_IS_LITTLE_ENDIAN -DNSS_BEVAND_ARCFOUR -DMPI_AMD64 -DMP_ASSEMBLY_MULTIPLY -DNSS_USE_COMBA -DUSE_HW_AES -DINTEL_GCM -DWIN64 -D_AMD64_ -Iz:/build/build/src/security/nss/lib/freebl -Iz:/build/build/src/obj-firefox/security/nss/lib/freebl/freebl_freebl3 -Iz:/build/build/src/security/nss/lib/freebl/mpi -Iz:/build/build/src/security/nss/lib/freebl/ecl -Iz:/build/build/src/security/nss/lib/freebl/verified -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/private/nss -Iz:/build/build/src/obj-firefox/dist/include/nss -Iz:/build/build/src/obj-firefox/dist/include -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4244 -wd4267 -we4553 -Z7 -Oy- -deps.deps/desblapi.obj.pp z:/build/build/src/security/nss/lib/freebl/desblapi.c 00:32:40 INFO - desblapi.c 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/security/nss/lib/freebl/freebl_freebl3' 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/security/nss/lib/freebl/freebl_freebl3' 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/security/nss/lib/freebl/freebl_freebl3' 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/media/webrtc/trunk/gtest' 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/media/webrtc/trunk/gtest' 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/mfbt/tests' 00:32:40 INFO - TestLinkedList.exe 00:32:40 INFO - z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x64/link.exe -nologo -out:TestLinkedList.exe -pdb:TestLinkedList.pdb @z:/build/build/src/obj-firefox/mfbt/tests/TestLinkedList_exe.list -SUBSYSTEM:CONSOLE,6.01 -STACK:2097152 -LARGEADDRESSAWARE -NXCOMPAT -RELEASE -DYNAMICBASE -DEBUG -DEBUGTYPE:CV kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib 00:32:40 INFO - Creating library TestLinkedList.lib and object TestLinkedList.exp 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/mfbt/tests' 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/media/webrtc/trunk/gtest' 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/media/webrtc/trunk/gtest' 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/mozglue/tests/interceptor' 00:32:40 INFO - z:/build/build/src/sccache2/sccache.exe z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x64/cl.exe -FoTestDllInterceptorCrossProcess.obj -c -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DMOZ_HAS_MOZGLUE -Iz:/build/build/src/mozglue/tests/interceptor -Iz:/build/build/src/obj-firefox/mozglue/tests/interceptor -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/testing -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Oy- -WX -deps.deps/TestDllInterceptorCrossProcess.obj.pp z:/build/build/src/mozglue/tests/interceptor/TestDllInterceptorCrossProcess.cpp 00:32:40 INFO - TestDllInterceptorCrossProcess.cpp 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/mozglue/tests/interceptor' 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/components/telemetry/pingsender' 00:32:40 INFO - z:/build/build/src/sccache2/sccache.exe z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x64/cl.exe -FoUnified_cpp_pingsender0.obj -c -DDEBUG=1 -DMOZ_HAS_MOZGLUE -Iz:/build/build/src/toolkit/components/telemetry/pingsender -Iz:/build/build/src/obj-firefox/toolkit/components/telemetry/pingsender -Iz:/build/build/src/toolkit/crashreporter/google-breakpad/src -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Oy- -WX -deps.deps/Unified_cpp_pingsender0.obj.pp z:/build/build/src/obj-firefox/toolkit/components/telemetry/pingsender/Unified_cpp_pingsender0.cpp 00:32:40 INFO - Unified_cpp_pingsender0.cpp 00:32:40 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/components/telemetry/pingsender' 00:32:40 INFO - z:/build/build/src/config/recurse.mk:74: recipe for target 'mozglue/tests/interceptor/target' failed 00:32:40 INFO - mozmake.EXE[3]: *** [mozglue/tests/interceptor/target] Error 2 00:32:40 INFO - mozmake.EXE[3]: *** Waiting for unfinished jobs.... 00:32:40 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/components/telemetry/pingsender'
Flags: needinfo?(aklotz)
Flags: needinfo?(aklotz)
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e491d518d61ac4980e2b9c422608356256fa180 Bug 1460022: Part 1 - Modify DLL interceptor to use one-time initialization when setting hooks; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/d1e8418da3b446ecfe81495ac484abace554b5cf Bug 1460022: Part 2 - Update TestDllInterceptor to use new DLL interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/7bdadc37becdd1c800543396b19a3d8f2c114e08 Bug 1460022: Part 3 - Update TestDllInterceptorCrossProcess to reflect new interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/f538fbf4d5099cbd84c3777d5eb338333dca33a4 Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie https://hg.mozilla.org/integration/mozilla-inbound/rev/388defa609728a5bcacd0bb48f461f5fca783e0e Bug 1460022: Part 5 - Update launcher process to work with new DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/137f27a03ba3b56b87a698adc34cbcf4b2def52f Bug 1460022: Part 6 - Update GMP code to work with new DLL interceptor interface; r=cpearce https://hg.mozilla.org/integration/mozilla-inbound/rev/88494d07fbcd14ced0c83f00c12b4bae5d566b48 Bug 1460022: Part 7 - Update plugin code to work with revised DLL interceptor interface; r=handyman https://hg.mozilla.org/integration/mozilla-inbound/rev/528b5685d597db2680e356bbd67fc52e575e3853 Bug 1460022: Part 8 - Update DLL blocklist to work with revised DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/097d82eb192888b55fc00cc6ccba78098afda4cf Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen https://hg.mozilla.org/integration/mozilla-inbound/rev/9c21c99f6b7703765f86b5860c0d4e5462e7ed2a Bug 1460022: Part 10 - Update crash reporter to work with revised DLL interceptor interface; r=dmajor https://hg.mozilla.org/integration/mozilla-inbound/rev/c95140bcd817476c28d70fc2f749ae94b4abc3e6 Bug 1460022: Part 11 - Update Win32 nsWindow to work with revised DLL interceptor interface; r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/1cdba0bde1857d2c8611fceaaa5f1d9fc6168ff6 Bug 1460022: Part 12 - Update XPCOM to use revised DLL interceptor interface; r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/ff25e66da36e4c95363e684880085f99d845da2a Bug 1460022: Part 13 - Update profiler to use revised DLL interceptor interface; r=njn
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: