Closed
Bug 1460002
Opened 6 years ago
Closed 6 years ago
[meta] Interceptor AddHook calls should only be attempted once
Categories
(Core :: General, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Keywords: crash, meta, Whiteboard: inj+)
Crash Data
Any code that uses the DLL interceptor should distinguish between "hook hasn't been attempted to be set yet" and "hook was attempted but failed."
In other words, if an AddHook call fails once, it's going to fail again. Any code that calls AddHook should not be in a position to repeatedly call AddHook over and over, as this needlessly consumes VM, and in the new world of shared trampoline space, will "crowd out" other interceptor instances.
Assignee | ||
Updated•6 years ago
|
Crash Signature: [@ mozilla::interceptor::VMSharingPolicyUnique<T>::GetNextTrampoline]
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Whiteboard: inj+
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Blocks: memshrink-content
Assignee | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Assignee: nobody → aklotz
status-firefox63:
--- → fixed
status-firefox-esr52:
--- → wontfix
status-firefox-esr60:
--- → wontfix
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•