Closed Bug 1460002 Opened 6 years ago Closed 6 years ago

[meta] Interceptor AddHook calls should only be attempted once

Categories

(Core :: General, enhancement, P3)

Product:
Core
Component:
General
Platform:
Unspecified
Windows
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

(Keywords: crash, meta, Whiteboard: inj+)

Crash Data

Any code that uses the DLL interceptor should distinguish between "hook hasn't been attempted to be set yet" and "hook was attempted but failed." In other words, if an AddHook call fails once, it's going to fail again. Any code that calls AddHook should not be in a position to repeatedly call AddHook over and over, as this needlessly consumes VM, and in the new world of shared trampoline space, will "crowd out" other interceptor instances.
Depends on: 1459335
Depends on: 1460003
Depends on: 1460005
Depends on: 1460006
Depends on: 1460007
Crash Signature: [@ mozilla::interceptor::VMSharingPolicyUnique<T>::GetNextTrampoline]
Depends on: 1460022
Priority: -- → P3
Whiteboard: inj+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → aklotz
status-firefox60: affected → wontfix
status-firefox61: affected → wontfix
status-firefox62: affected → wontfix
status-firefox63: --- → fixed
status-firefox-esr52: --- → wontfix
status-firefox-esr60: --- → wontfix
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.