1460074 - Still cannot switch between years in date picker

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

Attachment: datepicker year selection.mp4

The date picker control is overflowing our dialogue on my phone, so after switching to year selection mode I can only scroll the whole control up and down within the dialogue, but not actual the year selection list itself.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: datepicker - scrolling years locked in landscape.mp4

I was able to reproduce this on http://www.456bereastreet.com/lab/html5-input-types/ with the device in landscape.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

The current implementation which uses platform's DatePicker has it's share of bugs which we'll need to resolve.
Keeping my NI to return to this after the Oreo features and bugs which we currently work on are resolved.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Removing my NI from individual Date/TimePicker tickets, as they will be tracked in the new bug 1464997.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1460074 - Still cannot switch between years in date picker;

The problem stemmed from having the DatePicker inside a ScrollView which
was receiving the swipe events.
To avoid this I've created the new FocusableDatePicker which has the ability
to prevent it's parent from receiving touch events.

Review commit: https://reviewboard.mozilla.org/r/256578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256578/

Comment 5

[Petru-Mugurel Lingurar [:petru]]

How it will all work and look - https://drive.google.com/file/d/1vpUCafy6klA9hPqqxRKgHovwmnp1-zRg/view?usp=sharing

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8991656 [details]
Bug 1460074 - Still cannot switch between years in date picker;

https://reviewboard.mozilla.org/r/256578/#review263732

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/085439248886
Still cannot switch between years in date picker; r=jchen

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 085439248886 (bug 1460074) for lint build bustages on FocusableDatePicker.java

Backout: https://hg.mozilla.org/integration/autoland/rev/465f6e311e6db2cfda4ca5400c43cbd7ced82619

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=085439248886587f2251cb950de08bbbf0b70f6d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&filter-classifiedState=unclassified&selectedJob=188340754

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188340754&repo=autoland&lineNumber=883

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8991656 [details]
Bug 1460074 - Still cannot switch between years in date picker;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256578/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64e8e5c96ffa
Still cannot switch between years in date picker; r=jchen

Comment 11

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/64e8e5c96ffa

Comment 12

[Stefan Deiac]

Verified as fixed on Nightly 63.a01 (2018-07-26). Device: Motorola Nexus 6 (Android 7.1.1) and Samsung Galaxy S8 (Android 8.0)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8991656 [details]
Bug 1460074 - Still cannot switch between years in date picker;

Approval Request Comment
[Feature/Bug causing the regression]: DatePicker doesn't allow selecting years.
[User impact if declined]: DatePicker doesn't allow selecting years.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Has been QE verified and in the time being in Nightly no issues have been reported. 
[String changes made/needed]: --

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8991656 [details]
Bug 1460074 - Still cannot switch between years in date picker;

One of several small fixes for the date picker related to the switch in 62 to using the platform library. Verified in nightly. 
Let's uplift for next Monday's beta 17 build.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6eea74660c1c

Comment 17

[Ioana Chiorean]

Can you please check this, Igor?

Comment 18

[Bogdan Surd, QA [:bsurd, NI]]

Device:
 - Samsung Galaxy Note 8 (Android 8.0.0)

Verified as fixed in 62.0b17 the year picker works as mentioned in Comment 5.