Closed Bug 1460074 Opened 3 years ago Closed 2 years ago

Still cannot switch between years in date picker

Categories

(Firefox for Android :: General, defect)

Firefox 62
All
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified
firefox63 --- verified

People

(Reporter: JanH, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [priority:medium])

Attachments

(3 files)

The date picker control is overflowing our dialogue on my phone, so after switching to year selection mode I can only scroll the whole control up and down within the dialogue, but not actual the year selection list itself.
Flags: needinfo?(petru.lingurar)
I was able to reproduce this on http://www.456bereastreet.com/lab/html5-input-types/ with the device in landscape.
The current implementation which uses platform's DatePicker has it's share of bugs which we'll need to resolve.
Keeping my NI to return to this after the Oreo features and bugs which we currently work on are resolved.
Whiteboard: [priority:medium]
Blocks: 1464997
Removing my NI from individual Date/TimePicker tickets, as they will be tracked in the new bug 1464997.
Flags: needinfo?(petru.lingurar)
Assignee: nobody → petru.lingurar
Status: NEW → ASSIGNED
Attachment #8991656 - Flags: review?(sdaswani) → review?(nchen)
Comment on attachment 8991656 [details]
Bug 1460074 - Still cannot switch between years in date picker;

https://reviewboard.mozilla.org/r/256578/#review263732
Attachment #8991656 - Flags: review?(nchen) → review+
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/085439248886
Still cannot switch between years in date picker; r=jchen
Keywords: checkin-needed
Keywords: checkin-needed
Flags: needinfo?(petru.lingurar)
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64e8e5c96ffa
Still cannot switch between years in date picker; r=jchen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/64e8e5c96ffa
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Flags: qe-verify+
Verified as fixed on Nightly 63.a01 (2018-07-26). Device: Motorola Nexus 6 (Android 7.1.1) and Samsung Galaxy S8 (Android 8.0)
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Please nominate this for Beta approval when you get a chance.
Flags: needinfo?(petru.lingurar)
Comment on attachment 8991656 [details]
Bug 1460074 - Still cannot switch between years in date picker;

Approval Request Comment
[Feature/Bug causing the regression]: DatePicker doesn't allow selecting years.
[User impact if declined]: DatePicker doesn't allow selecting years.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Has been QE verified and in the time being in Nightly no issues have been reported. 
[String changes made/needed]: --
Flags: needinfo?(petru.lingurar)
Attachment #8991656 - Flags: approval-mozilla-beta?
Comment on attachment 8991656 [details]
Bug 1460074 - Still cannot switch between years in date picker;

One of several small fixes for the date picker related to the switch in 62 to using the platform library. Verified in nightly. 
Let's uplift for next Monday's beta 17 build.
Attachment #8991656 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Can you please check this, Igor?
Flags: needinfo?(igor.lazar)
Device:
 - Samsung Galaxy Note 8 (Android 8.0.0)

Verified as fixed in 62.0b17 the year picker works as mentioned in Comment 5.
Flags: qe-verify+
Flags: needinfo?(igor.lazar)
You need to log in before you can comment on or make changes to this bug.