Closed Bug 1460208 Opened Last year Closed Last year

Add learn more link to autoplay media

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- verified

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

Attachments

(1 file, 1 obsolete file)

I didnt want to block https://bugzilla.mozilla.org/show_bug.cgi?id=1458249 on this since I dont know where that link is going to go yet
Bryant, another one for you, does this url exist yet or who do we need to ping to get it done? Cheers
Flags: needinfo?(bmao)
Assignee: nobody → dharvey
This looks like active work on an active project, so marking P1 for now.
Priority: -- → P1
(In reply to Dale Harvey (:daleharvey) from comment #1)
> Bryant, another one for you, does this url exist yet or who do we need to
> ping to get it done? Cheers

Hey Dale, the URL link for the 'learn more' does not exist yet. I expect it will lead to our future autoplay policy page, but it might take a while until our autoplay approach is stabilized. I think this one has lower priority and shouldn't block other bugs.
Flags: needinfo?(bmao)
Deassigning until we are ready to get the assets for this
Assignee: dharvey → nobody
Cindy will provide the SUMO page content for Michelle to review
Flags: needinfo?(chsiang)
Here is the draft. Waiting for the review by Joni. 
https://docs.google.com/document/d/1BcSo-cqR2PLrgZDUp9oGVmbk3D2zGCMiLaOTKLacAr0/edit?usp=sharing
Flags: needinfo?(chsiang) → needinfo?(jsavage)
Dale, Cpearce
Here is the link to the SUMO page. Content is not up yet
https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/block-autoplay
The page is up now. The link in comment #7 will redirect to https://support.mozilla.org/kb/block-autoplay
Flags: needinfo?(jsavage)
Thanks Joni!
Assignee: nobody → dharvey
Add the learn more link to preferences as specced in https://mozilla.invisionapp.com/share/N2MD6ZV8CMG#/screens/306583372
Attachment #9001584 - Flags: review?(jhofmann)
Attachment #9001584 - Flags: review?(francesco.lodolo)
Comment on attachment 9001584 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001584 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #9001584 - Flags: review?(francesco.lodolo) → review+
Blocks: 1484152
Comment on attachment 9001584 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001584 [details] [diff] [review]:
-----------------------------------------------------------------

Please use "app.support.baseURL" for building the support URL.

I know that the other code there uses their own prefs, but I want to avoid adding to that list since this sets a precedent for more folks to pile on.

Most code hardcodes the path component ("block-autoplay"), but you could also put it in a pref if you prefer. FWIW if the path changes usually sumo folks just do a redirect on their end, I think.

Thanks!
Attachment #9001584 - Flags: review?(jhofmann) → review-
Yeh reusing the same pref for the url seems much better, followed the wrong example, switched to use baseURL, hardcoding the path seems fine here
Attachment #9001584 - Attachment is obsolete: true
Attachment #9001909 - Flags: review?(jhofmann)
Comment on attachment 9001909 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001909 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/components/preferences/in-content/privacy.js
@@ +1109,5 @@
>    // MEDIA
>  
> +  initAutoplay() {
> +    let url = Services.urlFormatter.formatURLPref("app.support.baseURL") +
> +        "block-autoplay";

nit: use 2 spaces indent
Attachment #9001909 - Flags: review?(jhofmann) → review+
Comment on attachment 9001909 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001909 [details] [diff] [review]:
-----------------------------------------------------------------

You'll need l10n review to land ftl files...
Attachment #9001909 - Flags: review?(francesco.lodolo)
Comment on attachment 9001909 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001909 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I think we can carry that over, be sure to add it to the commit message...
Attachment #9001909 - Flags: review?(francesco.lodolo) → review+
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66cc6cdb59f5
Add learn more link to preferences. r=johannh, r=flod
https://hg.mozilla.org/mozilla-central/rev/66cc6cdb59f5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Verified, that Block Autoplay "Learn more..." link is added and functional on Nightly 63.0a1(20180821100053).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.