1460208 - Add learn more link to autoplay media

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Dale Harvey (:daleharvey)]

I didnt want to block https://bugzilla.mozilla.org/show_bug.cgi?id=1458249 on this since I dont know where that link is going to go yet

Comment 1

[Dale Harvey (:daleharvey)]

Bryant, another one for you, does this url exist yet or who do we need to ping to get it done? Cheers

Comment 2

[Mike Conley (:mconley) (:⚙️)]

This looks like active work on an active project, so marking P1 for now.

Comment 3

[Bryant Mao [:bryantmao]]

(In reply to Dale Harvey (:daleharvey) from comment #1)
> Bryant, another one for you, does this url exist yet or who do we need to
> ping to get it done? Cheers

Hey Dale, the URL link for the 'learn more' does not exist yet. I expect it will lead to our future autoplay policy page, but it might take a while until our autoplay approach is stabilized. I think this one has lower priority and shouldn't block other bugs.

Comment 4

[Dale Harvey (:daleharvey)]

Deassigning until we are ready to get the assets for this

Comment 5

[chsiang]

Cindy will provide the SUMO page content for Michelle to review

Comment 6

[chsiang]

Here is the draft. Waiting for the review by Joni. 
https://docs.google.com/document/d/1BcSo-cqR2PLrgZDUp9oGVmbk3D2zGCMiLaOTKLacAr0/edit?usp=sharing

Comment 7

[chsiang]

Dale, Cpearce
Here is the link to the SUMO page. Content is not up yet
https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/block-autoplay

Comment 8

[Joni Chan]

The page is up now. The link in comment #7 will redirect to https://support.mozilla.org/kb/block-autoplay

Comment 9

[chsiang]

Thanks Joni!

Comment 10

[Dale Harvey (:daleharvey)]

Attachment: 0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Add the learn more link to preferences as specced in https://mozilla.invisionapp.com/share/N2MD6ZV8CMG#/screens/306583372

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 9001584 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001584 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 12

[Johann Hofmann [:johannh]]

Comment on attachment 9001584 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001584 [details] [diff] [review]:
-----------------------------------------------------------------

Please use "app.support.baseURL" for building the support URL.

I know that the other code there uses their own prefs, but I want to avoid adding to that list since this sets a precedent for more folks to pile on.

Most code hardcodes the path component ("block-autoplay"), but you could also put it in a pref if you prefer. FWIW if the path changes usually sumo folks just do a redirect on their end, I think.

Thanks!

Comment 13

[Dale Harvey (:daleharvey)]

Attachment: 0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Yeh reusing the same pref for the url seems much better, followed the wrong example, switched to use baseURL, hardcoding the path seems fine here

Comment 14

[Johann Hofmann [:johannh]]

Comment on attachment 9001909 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001909 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/components/preferences/in-content/privacy.js
@@ +1109,5 @@
>    // MEDIA
>  
> +  initAutoplay() {
> +    let url = Services.urlFormatter.formatURLPref("app.support.baseURL") +
> +        "block-autoplay";

nit: use 2 spaces indent

Comment 15

[Johann Hofmann [:johannh]]

Comment on attachment 9001909 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001909 [details] [diff] [review]:
-----------------------------------------------------------------

You'll need l10n review to land ftl files...

Comment 16

[Johann Hofmann [:johannh]]

Comment on attachment 9001909 [details] [diff] [review]
0001-Bug-1460208-Add-learn-more-link-to-preferences.-r-jo.patch

Review of attachment 9001909 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I think we can carry that over, be sure to add it to the commit message...

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66cc6cdb59f5
Add learn more link to preferences. r=johannh, r=flod

Comment 18

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/66cc6cdb59f5

Comment 19

[Gyula Palko[:gpalko]]

Verified, that Block Autoplay "Learn more..." link is added and functional on Nightly 63.0a1(20180821100053).