1484152 - Add learn more link to autoplay doorhanger

Status: VERIFIED FIXED

(Firefox :: Site Identity, enhancement, P1)

Description

[Dale Harvey (:daleharvey)]

+++ This bug was initially created as a clone of Bug #1460208 +++

I didnt want to block https://bugzilla.mozilla.org/show_bug.cgi?id=1458249 on this since I dont know where that link is going to go yet

Comment 1

[Dale Harvey (:daleharvey)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1460208 adds it to the preferences, in the spec there is also a link in the doorhanger https://mozilla.invisionapp.com/share/N2MD6ZV8CMG#/screens/306583374

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: 0001-Bug-1484152-Add-learn-more-link-to-autoplay-doorhang.patch

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 9001913 [details] [diff] [review]
0001-Bug-1484152-Add-learn-more-link-to-autoplay-doorhang.patch

Review of attachment 9001913 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/PermissionUI.jsm
@@ +798,5 @@
>    },
>  
>    get popupOptions() {
> +    let learnMoreURL =
> +        Services.urlFormatter.formatURLPref("app.support.baseURL") + "block-autoplay";

nit: 2 spaces please

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80bb488144c9
Add learn more link to autoplay doorhanger. r=johannh

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/80bb488144c9

Comment 6

[Gyula Palko[:gpalko]]

Verified, that "Learn more..." link is added to autoplay doorhanger on Nightly 63.0a1(20180828220157).