1460255 - Allow to build both GLX and EGL OpenGL backends for X11/Wayland builds

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

This is a follow up from Bug 788319 comment 47

In order to make Wayland builds usable, implement run-time GL context switch to use GLX on X11 and EGL on Wayland.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: WIP patch

Jeff, what do you think about this approach? It will leave X11/GLX backend as is and we can fix/update EGL for Wayland backend only.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1460255 - Implement GLContextProviderWayland,

GLContextProviderWayland provides both GLX and EGL GL backends on Wayland enabled builds
regard an active Gtk+ backend (X11/Wayland).

Review commit: https://reviewboard.mozilla.org/r/244010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244010/

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1460255 - Use GLContextProviderWayland GL provider on Wayland enabled builds,

Review commit: https://reviewboard.mozilla.org/r/244012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244012/

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1460255 - Use gfxXlibSurface::GetGLXPixmap() on GLX only,

gfxXlibSurface::GetGLXPixmap() is provided by GL_PROVIDER_GLX but
GL_PROVIDER_GLX is not defined by Wayland target.

Don't export gfxXlibSurface::GetGLXPixmap() on Wayland now and leave that
for further fixes.

Review commit: https://reviewboard.mozilla.org/r/244014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244014/

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8975816 [details]
Bug 1460255 - Implement GLContextProviderWayland,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244010/diff/1-2/

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8975817 [details]
Bug 1460255 - Use GLContextProviderWayland GL provider on Wayland enabled builds,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244012/diff/1-2/

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8975818 [details]
Bug 1460255 - Use gfxXlibSurface::GetGLXPixmap() on GLX only,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244014/diff/1-2/

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8975816 [details]
Bug 1460255 - Implement GLContextProviderWayland,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244010/diff/2-3/

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8975817 [details]
Bug 1460255 - Use GLContextProviderWayland GL provider on Wayland enabled builds,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244012/diff/2-3/

Comment 10

[Martin Stránský [:stransky] (ni? me)]

This is the last missing piece to build Wayland enabled builds on Linux/Gtk.

Comment 11

[Lee Salzman [:lsalzman]]

Comment on attachment 8975816 [details]
Bug 1460255 - Implement GLContextProviderWayland,

https://reviewboard.mozilla.org/r/244010/#review253364

Comment 12

[Lee Salzman [:lsalzman]]

Comment on attachment 8975817 [details]
Bug 1460255 - Use GLContextProviderWayland GL provider on Wayland enabled builds,

https://reviewboard.mozilla.org/r/244012/#review253366

Comment 13

[David Heidelberg [:okias]]

(In reply to Martin Stránský [:stransky] from comment #10)
> This is the last missing piece to build Wayland enabled builds on Linux/Gtk.

since it's reviewed, can it be pushed?

Comment 14

[Martin Stránský [:stransky] (ni? me)]

(In reply to David Heidelberg from comment #13)
> (In reply to Martin Stránský [:stransky] from comment #10)
> > This is the last missing piece to build Wayland enabled builds on Linux/Gtk.
> 
> since it's reviewed, can it be pushed?

Please wait until try finishes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f75e43ecb659cbafbeb2332f46eda0085fea971

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/446eb68ac1c3
Implement GLContextProviderWayland, r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/229a64156f70
Use GLContextProviderWayland GL provider on Wayland enabled builds, r=lsalzman

Comment 17

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/446eb68ac1c3
https://hg.mozilla.org/mozilla-central/rev/229a64156f70