1460256 - Update BuildDuty report dashboard to use the new component.

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Danut Labici [:dlabici]]

The BuildDuty Bugs Dashboard[1] doesn't pull bugs correctly anymore since our component was moved from RelEng to Infra&Ops.

Changes will be needed in buildduty_report.py[2] to pull the data from the correct product. 


[1] https://secure.pub.build.mozilla.org/builddata/reports/slave_health/buildduty_report.html
[2] https://dxr.mozilla.org/build-central/source/slave_health/scripts/buildduty_report.py?q=buildduty_report.py

Comment 1

[Danut Labici [:dlabici]]

Attachment: Change Parent and Bugzilla API fletch link.

Changes do:
===========
- Changed product name for options={} and loan_request_options={}
- Changed bugzilla rest api fletch url for options={}
- Changed how loan_request_options={} was written, to resemble options={} and keep consistency.

Comment 2

[Danut Labici [:dlabici]]

Changes left to be done:
========================
Get "Loan Requests" component back, update the rest api url for loaners.

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8974384 [details] [diff] [review]
Change Parent and Bugzilla API fletch link.

Review of attachment 8974384 [details] [diff] [review]:
-----------------------------------------------------------------

nice catch with %26" :)

Comment 4

[Danut Labici [:dlabici]]

Attachment: Added changes to fetch loaners using status_whiteboard

Other patch can be ignored, as this contains all changes.

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 8974394 [details] [diff] [review]
Added changes to fetch loaners using status_whiteboard

Review of attachment 8974394 [details] [diff] [review]:
-----------------------------------------------------------------

putting r- into the parts I mentioned are  commented on.

::: scripts/buildduty_report.py
@@ +183,4 @@
>                          )
>      parser.add_argument("-v", "--verbose", action="store_const", const=logging.DEBUG, dest="log_level")
>      parser.add_argument("-q", "--quiet", action="store_const", const=logging.WARN, dest="log_level")
> +    parser.add_argument("-l", "--logfatus=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&component=Buildduty&product=Infrastructure %26 Operations&resolution=---&status_whiteboard=loaner&status_whiteboard_type=allwordssubstrile", dest="logfile")

This seems like weird syntax.

--logfatus ?

does space work in: "Infrastructure %26 Operations" ?

resolution=---&status_whiteboard=loaner ?

allwordssubstrile ?

I may not be the best to review this as I'm not familiar with bugzilla url syntax and these command line options.

Comment 6

[Danut Labici [:dlabici]]

Not entirely sure how parser.add_argument("-l",... got changed. Also the space in "Infrastructure %26 Operations" will not work either, but again... that line shouldn't have been modified :o

As for the bugzilla url syntax, I had trouble making rest respond with the list of bugs with loaner whiteboard.
Link for the rest api results was generated using the following link:

https://bugzilla.mozilla.org/buglist.cgi?list_id=14142106&status_whiteboard_type=allwordssubstr&status_whiteboard=loaner&resolution=---&query_format=advanced&component=Buildduty&product=Infrastructure%20%26%20Operations

And clicking on "REST" link (bottom left corner) which will redirect you to:
https://bugzilla.mozilla.org/rest/bug?include_fields=id,summary,status&component=Buildduty&product=Infrastructure%20%26%20Operations&resolution=---&status_whiteboard=loaner&status_whiteboard_type=allwordssubstr


For resolution=--- that is introduced by the HTML link for rest, I played around with it and if you remove it, you will get a list of ALL bug that had "loaner" in their whiteboard, while we only care of a few bug status types, such as: ['UNCONFIRMED','NEW','ASSIGNED','REOPENED']

Link with resolution: https://bugzilla.mozilla.org/rest/bug?include_fields=id,summary,status&component=Buildduty&product=Infrastructure%20%26%20Operations&resolution=---&status_whiteboard=loaner&status_whiteboard_type=allwordssubstr

Link without resolution: https://bugzilla.mozilla.org/rest/bug?include_fields=id,summary,status&component=Buildduty&product=Infrastructure%20%26%20Operations&status_whiteboard=loaner&status_whiteboard_type=allwordssubstr

Comment 7

[Danut Labici [:dlabici]]

Attachment: Fixed issues with the patch based on the review.

Comment 8

[Danut Labici [:dlabici]]

Patch pushed to repo:
https://hg.mozilla.org/build/slave_health/rev/e04219f2d5ab567ef42ff4c919033a4f726abf3b

Comment 9

[Danut Labici [:dlabici]]

Attachment: Force include REST fields to reflect the new way of fetching Loaner bugs.

Tested locally and works.

Comment 10

[Attila Craciun [:arny]]

Comment on attachment 8974940 [details] [diff] [review]
Force include REST fields to reflect the new way of fetching Loaner bugs.

Review of attachment 8974940 [details] [diff] [review]:
-----------------------------------------------------------------

Reviewing now to unblock.

Comment 11

[Danut Labici [:dlabici]]

Patch pushed to repo:
https://hg.mozilla.org/build/slave_health/rev/f755568563cac51d0fa0a2d6ce6fd4633a6ef731

Comment 12

[Danut Labici [:dlabici]]

Cron job triggered and everything is back in a working state!