1460554 - Changing KeyframeEffect doesn't affect at all if devtools inspector is open

Status: RESOLVED DUPLICATE of bug 1459536

(Core :: DOM: Animation, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: An example

I don't understand what happens there at all. :/

Attaching file has a CSS animation whose effect is changed soon.  If devtools inspector is open, the animation seems not work at all.  I haven't debugged yet.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I did look at this a little bit last night.  When devtools inspector opens, we do somehow restyle whole document, thus the original CSS animation keyframes overrides the changed effect.  I guess devtools inspector injects some CSS rules in the document.  That means all modified CSS animations/transitions will be affected by this.

Comment 2

[Brian Birtles (:birtles)]

I guess we're failing to track when the effect has been overridden. I guess we could fix this as part of bug 1459536 (where we need to do similar tracking at the timing properties / keyframes level).

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Yeah, 1459536 should fix this actually.  I was wondering why the animation in question is updated, because I thought Emilio did an optimization that we don't update CSS animations when CSS rule for keyframes isn't changed.  But actually the optimization [1] is just checking existence of CSS animations.  So, this bug will be also fixed by another optimization that we check the keyframe rules changes there.

[1] https://hg.mozilla.org/mozilla-central/file/47e81ea1ef10/servo/components/style/matching.rs#l259

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Depending bug 1459536 for now.

Comment 5

[Brian Birtles (:birtles)]

Confirming that the patches in bug 1459536 appear to fix this for me.