1460631 - gflags.cc cannot find its config.h (config.h.in not processed) for MinGW build

Status: RESOLVED INCOMPLETE

(Core :: WebRTC, defect, P2)

Description

[Honza Bambas (:mayhemer)]

Not duplicate of bug 1412613!

41:54.05 Unified_cpp_third_party_gflags0.cpp
41:54.05 C:/Mozilla/src/mozilla-central/media/webrtc/trunk/third_party/gflags/src/gflags.cc(91): fatal error C1083: Cannot open include file: 'config.h': No such file or directory
41:54.07 mozmake.EXE[4]: *** [C:/Mozilla/src/mozilla-central/config/rules.mk:1032: Unified_cpp_third_party_gflags0.obj] Error 2
41:54.07 mozmake.EXE[3]: *** [C:/Mozilla/src/mozilla-central/config/recurse.mk:73: media/webrtc/trunk/third_party/gflags/gflags_gflags/target] Error 2
41:54.07 mozmake.EXE[3]: *** Waiting for unfinished jobs....


This is the failing include:

// This comes first to ensure we define __STDC_FORMAT_MACROS in time.
> #include <config.h>
#if defined(HAVE_INTTYPES_H) && !defined(__STDC_FORMAT_MACROS)

Comment 1

[Honza Bambas (:mayhemer)]

BTW, this happens to me with a nearly empty mozconfig.  Is webrtc already enabled by default to build on windows?

Comment 2

[Tom Ritter [:tjr]]

(In reply to Honza Bambas (:mayhemer) from comment #1)
> BTW, this happens to me with a nearly empty mozconfig.  Is webrtc already
> enabled by default to build on windows?

If you're trying to build on Linux with MinGW for Windows (or on Windows with the MinGW toolchain instead of a Mozillabuild setup although I don't have any experience with that one) - then no. We --disable-webrtc.

Comment 3

[Honza Bambas (:mayhemer)]

(In reply to Tom Ritter [:tjr] from comment #2)
> (In reply to Honza Bambas (:mayhemer) from comment #1)
> > BTW, this happens to me with a nearly empty mozconfig.  Is webrtc already
> > enabled by default to build on windows?
> 
> If you're trying to build on Linux with MinGW for Windows (or on Windows
> with the MinGW toolchain instead of a Mozillabuild setup although I don't
> have any experience with that one) - then no. We --disable-webrtc.

I'm building the up-to-date mozilla-central with MozillaBuild 3.1.1.  So, I would expect, as you say, --disable-webrtc by default.  Adding it explicitly to my mozconf fixed the issue.

Comment 4

[Tom Ritter [:tjr]]

Last time I tried building WebRTC I did not get the same errors. I'm resolving the sub-bugs as Incomplete until I can go back to building WebRTC and if they are still applicable, I'll reopen.