comm-esr52 build busted - problem confirming the ssl certificate ... tlsv1 alert protocol version

RESOLVED INCOMPLETE

Status

defect
--
blocker
RESOLVED INCOMPLETE
Last year
6 months ago

People

(Reporter: wsmwk, Assigned: tomprince)

Tracking

52 Branch
Thunderbird 52.0

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(2 attachments)

Per Jorg, https://treeherder.mozilla.org/#/jobs?repo=comm-esr52 

Thed error is: Could not fetch URL https://pypi.python.org/simple/blessings/: There was a problem confirming the ssl certificate: [Errno 1] _ssl.c:510: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version - skipping 

bug 1286358?
No longer blocks: 1442893
No longer depends on: 1459393
kmoir is there an easy solution?
Flags: needinfo?(kmoir)
Callek	wsmwk: well, at least `Collecting blessings>=1.3 (from mozlog==3.4)` so mozlog requires blessings...
Callek	and it looks like its build system at first glance
Callek	wsmwk https://dxr.mozilla.org/comm-esr52/source/mail/test/resources/installmozmill.py#87
Callek	wsmwk: sooo, I think this is fallout from pypi no longer letting us use old TLS...
Callek	wsmwk: a workaround (not sure if its the best one) would be to vendor blessings into comm-esr52 and make that file installs it from the vendored local location
Flags: needinfo?(kmoir)
Comment on attachment 8975529 [details]
Bug 1460726: Install packages from internal pypi mirror.

Philipp Kewisch [:Fallen]  has approved the revision.

https://phabricator.services.mozilla.com/D1276
Attachment #8975529 - Flags: review+
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Comment on attachment 8975529 [details]
Bug 1460726: Install packages from internal pypi mirror.

This is causing tests to fail.
Attachment #8975529 - Flags: approval-comm-esr52?
Attachment #8975529 - Flags: approval-comm-esr52? → approval-comm-esr52+
Only for TB 52 or also 62 and 61 (beta)?
We should consider something like this for comm-beta/comm-central, but they have diverged enough that this patch doesn't apply.
Tom or Philipp, can you land this please? (Jorg is not set up to land from Phabricator.
 THanks
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
I don't have a comm-esr52 tree ready for landing. Here is all you need to do:

hg import https://phabricator.services.mozilla.com/D1276?download=true
hg push
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
(In reply to Philipp Kewisch [:Fallen]  from comment #9)
> hg import https://phabricator.services.mozilla.com/D1276?download=true
That's only part of the deal. That doesn't give a commit message and the patch author is wrong, too.
So one needs to follow up with:
hg commit --amend --user "Tom Prince <mozilla@hocat.ca>"

Landed as:
https://hg.mozilla.org/releases/comm-esr52/rev/48295e2bf1df191ef4ec3010d496030ea8164730
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Version: Trunk → 52 Branch
That killed the Mac build which was previously working.
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
Sorry, that busted all builds :-(
Posted file Fix - v2 β€”
Untested, but based on the error message this should take care.
Flags: needinfo?(philipp)
Attachment #8975838 - Flags: review?(mozilla)
Comment on attachment 8975838 [details]
Fix - v2

`envion` is misspelled (missing an `r`).
Flags: needinfo?(mozilla)
Attachment #8975838 - Flags: review?(mozilla) → review-
It doesn't in automation. People running it locally might run into problems without it. But that should be enough for us to go-to-build with.
(In reply to Tom Prince [:tomprince] from comment #16)
> It doesn't in automation.
Well, if it doesn't then there's something else wrong:
AttributeError: _Environ instance has no __call__ method

I'm happy for the experts to fix this instead of me doing it by try and error :-(
Gah, I had s/()/[]/ in my original patch. But doing `.get` is reasonable.
Still

Could not fetch URL https://pypi.python.org/simple/blessings/: There was a problem confirming the ssl certificate: [Errno 1] _ssl.c:510: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version - skipping

You want to try with brackets instead of parenthesis and drop the .get? Then spell out the line here.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
Somehow there is no test coverage :-(

esr52 in all its incarnations is dead

Status: REOPENED → RESOLVED
Closed: Last year6 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.