Clean-up native widget resizer awareness of RTL/writing-mode

NEW
Unassigned

Status

()

enhancement
P5
normal
Last year
6 months ago

People

(Reporter: timdream, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=C++])

With bug 1459646 and bug 1450017, minimal-xul.css & nsScrollbarFrame are the only places we figure out set the resizer direction and style. There is no need for the widget code to peek into IsFrameRTL() when rendering the resizer.

We should remove the feature from widget code. The tests should be kept and this bug should be linked to the bugs implementing the features.
I won't be able to review the code change but I am happy to point out where they are if there is any contributor willing to work on it.
Mentor: timdream
Whiteboard: [lang=C++]
Hello, I'll give it a shot. From what you described, I understand that I should remove all the IsFrameRTL() calls from widget. That would mean to remove it from all nsNativeTheme*.* files, even though it is heavily used (in nsNativeThemeWin.cpp) , right? IsFrameRTL() is also used as assignment value in branches (e.g. line 1127 in nsNativeThemeWin.cpp) so I'm not sure how to proceed. I'm waiting for your feedback. Thanks.
First, let's ask Neil if he has other thoughts. You should ask him for review.

(In reply to Petru Gurita from comment #2)

You should only identify and remove the IsFrameRTL() calls for rendering native resizers, not all the calls in the entire file.
Flags: needinfo?(enndeakin)
Clearing expired ni.
Flags: needinfo?(enndeakin)
Mentor: timdream
You need to log in before you can comment on or make changes to this bug.