1461173 - TEST-UNEXPECTED-FAIL |[snip]\mozmill\account\test-archive-options.js | test-archive-options.js::test_disable_archive on Windows only

Status: NEW

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | Z:\task_1525989362\build\tests\mozmill\account\test-archive-options.js | test-archive-options.js::test_disable_archive

First seen:
Thu, May 10, 2018, 22:11:44.

M-C last good: 76aad17f5b50a1b969eec8cbb5aa987555
M-C first bad: 17db33b6a124422d43a9f518bea1bc62a6

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=76aad17f5b50a1b969eec8cbb5aa987555&tochange=17db33b6a124422d43a9f518bea1bc62a6

Comment 1

[:aceman]

It is strange that it fails only on Windows.

It always fails at the same code line (the target.ownerDocument call) in test-window-helpers.js, but sometimes 'target' is null, sometimes target.ownerDocument is null.

I added some debug output so the code is now like this:
 function getWindowDescribeyFromEvent(event) {
   var target = event.target;
   // assume it's a window if there's no ownerDocument attribute
+  dump(" ACE: tag="+target.tagName+" id="+target.id+" owner="+("ownerDocument" in target)+"\n");
   var win = ("ownerDocument" in target) ? target.ownerDocument.defaultView
                                         : target;

Then see the log at https://taskcluster-artifacts.net/RvFZKtkjRoaP1SqHZl0xqg/0/public/logs/live_backing.log :
14:05:34     INFO -   ACE: tag=undefined id=undefined owner=true
14:05:34     INFO -  JavaScript error: chrome://mozmill/content/modules/frame.js -> file:///Z:/task_1526219040/build/tests/mozmill/shared-modules/test-window-helpers.js, line 1549: TypeError: null has no properties

It is strange that at many occasions ("ownerDocument" in target) returns true as if the property exists in 'target' and then suddenly there is the error that 'target is null'.

I see nothing obvious in the pushlog.

I have pushed a more thorough debugging patch to try.

Comment 2

[Jorg K (CEST = GMT+2)]

The strangeness continues:
  mozmake SOLO_TEST=account/test-archive-options.js  mozmill-one
passes locally.

None of the errors
JavaScript error: chrome://mozmill/content/modules/frame.js -> file:///Z:/task_1526131024/build/tests/mozmill/shared-modules/test-window-helpers.js, line 1548: TypeError: target.ownerDocument is null
JavaScript error: chrome://mozmill/content/modules/frame.js -> file:///Z:/task_1526131024/build/tests/mozmill/shared-modules/test-window-helpers.js, line 1548: TypeError: null has no properties 
which we see in the server log are present.

Comment 3

[Intermittent Failures Robot]

4 failures in 521 pushes (0.008 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* comm-central: 4

Platform breakdown:
* windows7-32: 2
* windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1461173&startday=2018-06-18&endday=2018-06-24&tree=trunk

Comment 4

[Jorg K (CEST = GMT+2)]

Heaps of errors in the log:
https://taskcluster-artifacts.net/TnPZ23WORbeUyJyTVUX9Lw/0/public/logs/live_backing.log

JavaScript error: chrome://mozmill/content/modules/frame.js -> file:///Z:/task_1531352570/build/tests/mozmill/shared-modules/test-window-helpers.js, line 1548: TypeError: null has no properties

INFO -  TEST-START | Z:\task_1531352570\build\tests\mozmill\account\test-mail-account-setup-wizard.js | test_mail_account_setup
INFO -  -- Exception object --
INFO -  + _message (string) ''
INFO -  + stack (string) 2466 chars
INFO -  + code (number) 0
INFO -  + uri (string) 'http://autoconfig.example.com/mail/config-v1.1.xml'
INFO -  + constructor (function) 6 lines
INFO -  + message (string) ''
INFO -  + toString (function) 4 lines
INFO -  *
INFO -  -- Stack Trace --
INFO -  Exception@chrome://messenger/content/accountcreation/util.js:126:5
(stack continues)

INFO -  JavaScript error: resource:///modules/WinSearchIntegration.js, line 648: NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.leafName]
INFO -  JavaScript error: resource:///modules/activity/alertHook.js, line 44: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgMailNewsUrl.server]
INFO -  JavaScript error: resource:///modules/WinSearchIntegration.js, line 648: NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.leafName]
INFO -  JavaScript error: resource:///modules/activity/alertHook.js, line 44: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgMailNewsUrl.server]

Aceman, can we please move this forward.

Comment 5

[:aceman]

Attachment: 1461173.patch

We still do not know what happens here, but after the click the checkbox does not get unchecked. This will be visualized by this patch.
It only happens on Windows and only on the server. The window is in some strange state that's why there are the JavascriptErrors (JavaScript error: chrome://mozmill/content/modules/frame.js -> file:///Z:/task_1531998754/build/tests/mozmill/shared-modules/test-window-helpers.js, line 1548: TypeError: target.ownerDocument is null).

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8994061 [details] [diff] [review]
1461173.patch

OK. Sadly that doesn't fix anything :-(

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1461173-disable-test.patch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ed0230807d78
Tighten test test_disable_archive to detect if the archive checkbox is not in the expected state. r=jorgk
https://hg.mozilla.org/comm-central/rev/1d23d1a592cc
temporarily disable test-archive-options.js::test_disable_archive on Windows. rs=bustage-fix DONTBUILD

Comment 9

[Jorg K (CEST = GMT+2)]

Let's see what still fails:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=bca644bca6df422c55e7443f9292169cadb4a002

Comment 10

[Jorg K (CEST = GMT+2)]

Still fails.