1461248 - Only load ContextMenu.jsm when a contextmenu event occurs

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

An instance of the ContextMenu object is created for every tab (in content.js) only to add its event listener for the "contextmenu" event.

We can add this observer in content.js and only load the .jsm when that happens.

This patch uses the helper being added in bug 1457988

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1461248 - Only load ContextMenu.jsm when a contextmenu event occurs.

Review commit: https://reviewboard.mozilla.org/r/243698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243698/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8975391 [details]
Bug 1461248 - Only load ContextMenu.jsm when a contextmenu event occurs.

https://reviewboard.mozilla.org/r/243698/#review249640

defineLazyProxy looks awesome! Thanks, felipe!

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8975391 [details]
Bug 1461248 - Only load ContextMenu.jsm when a contextmenu event occurs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243698/diff/1-2/

Comment 4

[:Felipe Gomes (needinfo for replies!)]

I did some small shuffling around in content.js to make the code look cleaner: moved the `var global = this` to the top of the file, to group the XPCOMUtils stuff together. I'll carry the r+ forward since there's no functionality change.

I also removed the `var contextMenu = ` which was useless, but now I need to wait for bug 1462400 before landing this, otherwise eslint will complain

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43757e7a227f
Only load ContextMenu.jsm when a contextmenu event occurs. r=mconley

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/43757e7a227f