1462400 - Tell eslint about XPCOMUtils.defineLazyProxy

Status: RESOLVED FIXED

(Firefox Build System :: Lint and Formatting, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

ESLint needs to know about variables defined through XPCOMUtils.defineLazyProxy

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1462400 - Tell eslint about XPCOMUtils.defineLazyProxy.

Review commit: https://reviewboard.mozilla.org/r/244732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244732/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8976638 [details]
Bug 1462400 - Tell eslint about XPCOMUtils.defineLazyProxy.

https://reviewboard.mozilla.org/r/244732/#review251094

Can you also do me a favour and bump the eslint-plugin-mozilla versions in:

tools/lint/eslint/eslint-plugin-mozilla/package.json
tools/lint/eslint/eslint-plugin-mozilla/package-lock.json

Probably 0.13.0 will do. You can add it to this changeset. I forgot the other day when I landed some stuff.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8976638 [details]
Bug 1462400 - Tell eslint about XPCOMUtils.defineLazyProxy.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244732/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/905c4c76602d
Tell eslint about XPCOMUtils.defineLazyProxy. r=standard8

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/905c4c76602d

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/42a261531255c8daf244459cd4e820282653dd74
Merge pull request #5143 from escattone/improve-functional-tests-1462440

bug 1462400: Improve functional tests

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/15d58c811c0a90af3fa22a3012f3f050d6123832
bug 1462400: fix test_footer_language_selector test

https://github.com/mozilla/kuma/commit/76f6dbe4432d7d9da390e3129ccb2fe6455f58b5
Merge pull request #5163 from escattone/fix-footer-lang-select-test-1462400

bug 1462400: fix test_footer_language_selector test

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/d0aedf9f29564f8149634db309261912d5a11680
bug 1462400: fix test_header_signin and test_edit_sign_in

Both of these tests would sometimes fail due to their buttons
being obscured by the task-completion survey. Disable the survey
prior to clicking.

https://github.com/mozilla/kuma/commit/175a64503481eee2abfd087135b5afa46970f79d
Merge pull request #5166 from escattone/avoid-survey-obscuration-1462400

bug 1462400: fix test_header_signin and test_edit_sign_in