1461650 - Hard-to-read background tabs with CSD under KDE Plasma

Status: RESOLVED DUPLICATE of bug 1562507

(Core :: Widget: Gtk, defect, P2)

Description

[lykkeleg]

Attachment: Screenshot_20180515_143847.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180509235650

Steps to reproduce:

Choose Menu button → Customize … →uncheck Titlebar and choose Apply.

- With Default Theme (light and dark themes are unaffected)


Actual results:

Background (or 'inactive') tabs get dark text, making them hard to read.

Also affects Nightly (as of 15th May).

Reproduced under a new user profile.


Expected results:

Text should be readable – use whiter text colour?

Comment 1

[Timea Cernea [:tbabos][inactive]]

Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID:20180516032328

I couldn't reproduce the issue on Ubuntu 16.04 x64 with the steps provided in the report. However, I'm assigning a component in order to involve the development team to have a proper review on the issue.

Comment 2

[lykkeleg]

Thanks, Mr. Babos. I forgot to mention that I am using Plasma 5.12.5 (and KDE Neon, but it's basically Ubuntu 16.04 with newer KDE packages).

Comment 3

[Vlad Zahorodnii [:zzag]]

That's a bug related to the Breeze GTK theme. It seems like text color in the background tabs is the same as the text color in menubar. See https://gist.github.com/zzag/fa29ccb5ad842c172a8126ae73a8d507#file-gtk-css-L3757

Comment 4

[Dão Gottwald [:dao]]

See bug 1439834 comment 26.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613

Comment 7

[mthw0]

Just so you know, Chrome with the same theme doesn't have this issue.

Comment 8

[Darkspirit]

I use KDE on Debian Testing with Breeze GTK theme and it looks fixed: Nightly 70

Comment 9

[mthw0]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)

I use KDE on Debian Testing with Breeze GTK theme and it looks fixed: Nightly 70

AFAIK Debian doesn't use current Breeze-gtk theme (https://imgur.com/a/m7YtzH3). Maybe you could provide a screenshot?

Comment 10

[Julius B.]

This is still broken with Firefox 82 and Plasma 5.20. It makes the default theme unusable with Breeze window decorations. Mozilla, can we please get a fix?

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Can you please attach a screenshot of an opened menu in Firefox as well as of the titlebar with inactive text items?
Thanks.

Comment 12

[matejm98mthw]

Attachment: Screenshot_20201110_082343.png

Something like this?

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Yes, Thanks. That's exactly what Dao is talking about:

Theoretically yes, titlebar and menubar can be styled differently, but generally both uses the same text color. I checked some themes (Ubuntu Ambiance, default Adwaita, KDE Arc) and all has the same colors for titlebar color and hearedbar color.

As the titlebar/menubar color can be (and it's) styled, it's IMHO better to use the menubartext as it matches the styling somehow. The 100% fix would be to add -moz-titlebartext color but we'd rather leave that for further bug.

So to properly fix that we may need to add -moz-titlebartext css style here.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

If anyone is willing to help here I can provide a guide. It may be pretty a straightforward fix when we get proper style from titlebar widget:
https://searchfox.org/mozilla-central/source/widget/gtk/WidgetStyleCache.cpp#440
and export that to js code as -moz-titlebartext.

Comment 15

[Vlad Zahorodnii [:zzag]]

Heh, it seems like https://bugzilla.mozilla.org/show_bug.cgi?id=1562507 can be marked as a duplicate of this bug.