1461668 - fake "new release" behavior in Ship-it v1 staging by using shipitscript and Ship-it v2 staging

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, enhancement)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

Forgot to file this bug, I'm working on the patches. Will add more comments in a bit.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Note to self: add comprehensive `scopes.md` for the shipitscript repo.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Shipitscript changes to support Ship-it V1 communication

FWIW - this is the current PR I'm working on. 
Will need to tweak in-tree tasks as well.

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

First in-tree attempt on maple: https://hg.mozilla.org/projects/maple/rev/1b38998d6310b76b618d8596e6aa78ebec4f14cb

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

I added the following (staging scopes for now):

project:releng:ship-it:server:staging
project:releng:ship-it:action:mark-as-started
project:releng:ship-it:action:mark-as-shipped

under moz-tree:level:3:gecko role. Not ideal but we can revisit later. 

[1]: https://tools.taskcluster.net/auth/scopes/project%3Areleng%3Atreescript%3Aaction%3A*/role:moz-tree%3Alevel%3A3%3Agecko

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Worked like a charm! https://tools.taskcluster.net/groups/ezUNaGZ2QLO4707qmslrrQ/tasks/NtZYG4j2TPeQ4e4BxjgsvQ/details
We now have sync in between the two Ship-it versions! https://ship-it-dev.allizom.org/releases.html

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

To sum-it up:
* shipitscript PR is here[1]
* in-tree patch is here[2]
* scopes were amended in comment 4
* puppet changes are here[3]

Immediate leftovers for me:
* fix branch as it's now `maple` instead of `projects/maple`
* fix Submtted by field as it's now `shipit-scriptworker-stage`. Or maybe not? 
* test Fennec and Devedition altogether. Pay attention to l10n fields too. for Firefox it worked like a charm!

Future leftovers when we're ready to switch to production:
* uplift in-tree changes to central/beta
* land puppet changes to production and un-pin the dev worker
* merge shipitscript and bump a production version
* amend the production scopes as well, similarly to comment 4 but for production this time
* amend the in-tree kind to make sure it only runs for mozilla-beta and is ignored for the rest (check binary transparency model maybe or use the run-on-projects field)
* run a general end-to-end config diff to make sure I'm not breaking mark-as-shipped task in other projects/graphs and the existing one is looking good (mark-as-started)

[1]: https://github.com/mozilla-releng/shipitscript/pull/8
[2]: https://hg.mozilla.org/projects/maple/rev/1b38998d6310b76b618d8596e6aa78ebec4f14cb
[3]: https://github.com/MihaiTabara/build-puppet/tree/started

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

This worked like a charm in staging. More comments on leftover to roll this to production when the times comes in a few weeks, I filed 1466627.

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

FTR, follow-up fix on maple to fix l10nchangesets Fennec: https://hg.mozilla.org/projects/maple/rev/48d85c1f695f180133064428dfed85c7a904c236