Closed Bug 1461819 Opened 7 years ago Closed 7 years ago

Plack::Handler::Apache2 accidentally unsets $ENV{MOD_PERL}

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: dylan)

References

Details

Attachments

(1 file)

45 bytes, text/x-github-pull-request
Details | Review
It seems that Plack::Handler::Apache2 unsets $ENV{MOD_PERL}. It is using the pattern of calling local() first (making the hash slot have dynamic scope) and then deleting it, which shouldn't persist outside of the handler. Thanks to ckolos for pointing me at the weird behavior seen on prod; this explains some of it (such as why interdiff becomes a zombie). This is also probably a bug in Plack::Handler::Apache2, so I'm going to tweet at the author for guidance.
Found the upstream issue. There's a work around, but I wonder if there's a better fix.
Attached file PR
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: