1461890 - dom/presentation/tests/mochitest/test_presentation_1ua_connection_wentaway_inproc.html permafails with promise-to-nsISupports conversions turned off

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 1352644 comment 8.

The test needs to be run as:

  mach mochitest --disable-e10s dom/presentation/tests/mochitest/test_presentation_1ua_connection_wentaway_inproc.html

but with that it reproduces the failure quite reliably on Linux.

Comment 1

[Boris Zbarsky [:bzbarsky]]

https://searchfox.org/mozilla-central/source/dom/presentation/tests/mochitest/test_presentation_1ua_connection_wentaway.js does:

    var obs = SpecialPowers.Cc["@mozilla.org/observer-service;1"]
                           .getService(SpecialPowers.Ci.nsIObserverService);
    obs.notifyObservers(promise, 'setup-request-promise');

which attempts to pass a promise through nsISupports (as the observer message subject) first in the JS to C++ direction to the observer service and then in the C++ to JS direction going to observers.

There are other tests in this dir doing similar stuff.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Hmm. I'm not sure how I missed this when running tests ^_^. Do you know if we run into this issue anywhere else outside of tests? Should I just fix the tests or back out the promise/isupports changes :-/.

TBH I kinda expected this sort of thing to just sorta work by making an nsXPCWrappedJS object wrapping the promise as an nsISupports, but I suppose the other side is getting a wrapped nsXPCWrappedJS, and needs to tunnel through to the inner object explicitly D:

Comment 3

[Boris Zbarsky [:bzbarsky]]

> I'm not sure how I missed this when running tests

Did you run tests on the one single platform (32-bit Linux) where we run this test?  :(

> Do you know if we run into this issue anywhere else outside of tests?

I don't know, but I would guess not.

> Should I just fix the tests 

I think that would be simplest.

Comment 4

[Intermittent Failures Robot]

53 failures in 639 pushes (0.083 failures/push) were associated with this bug in the last 7 days. 

This is the #26 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-central: 28
* mozilla-inbound: 13
* autoland: 10
* try: 2

Platform breakdown:
* linux32: 53

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1461890&startday=2018-05-14&endday=2018-05-20&tree=trunk

Comment 5

[Geoff Brown [:gbrown]]

Test is no longer in tree.