remove old osx 10.6 references in manifest files

RESOLVED FIXED in Firefox 62

Status

()

P3
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jmaher, Assigned: apavel)

Tracking

54 Branch
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

(Whiteboard: [manifest_cleanup])

Attachments

(2 attachments, 5 obsolete attachments)

(Reporter)

Description

10 months ago
we run our automation on osx 10.10, not 10.6 or other lower versions.

We can remove references to older version in these manifest files:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/workers/semantics/structured-clone/dedicated.html.ini#224

and this file has many references:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/workers/semantics/structured-clone/shared.html.ini

in addition there are references to linux 12.04 which we can remove

Updated

10 months ago
Priority: -- → P3
(Assignee)

Comment 1

10 months ago
Posted file removed osX reference (obsolete) —
Attachment #8978995 - Flags: review?(gbrown)
(Assignee)

Comment 2

10 months ago
Posted patch removed other refrences (obsolete) — Splinter Review
Assignee: nobody → apavel
Attachment #8978997 - Flags: review?(gbrown)
(Assignee)

Comment 3

10 months ago
Posted file remove OSX reference (obsolete) —
The correct format.
Attachment #8978998 - Flags: review?(gbrown)
(Assignee)

Comment 4

10 months ago
Attachment #8978995 - Attachment is obsolete: true
Attachment #8978997 - Attachment is obsolete: true
Attachment #8978998 - Attachment is obsolete: true
Attachment #8978995 - Flags: review?(gbrown)
Attachment #8978997 - Flags: review?(gbrown)
Attachment #8978998 - Flags: review?(gbrown)
Attachment #8979159 - Flags: review?(gbrown)
(Assignee)

Comment 5

10 months ago
Attachment #8979169 - Flags: review?(gbrown)
(Reporter)

Comment 6

10 months ago
Comment on attachment 8979159 [details] [diff] [review]
patch 1 - updated Mac references

Review of attachment 8979159 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/meta/workers/semantics/structured-clone/dedicated.html.ini
@@ +221,4 @@
>  
>    [Number 0.2]
>      expected:
> +      if not debug and (os == "mac") and (version == "OS X 10.10") and (processor == "x86_64") and (bits == 64): TIMEOUT

I assume this runs successfully on osx 10.10 as there are no references to TIMEOUT for 10.10, only earlier versions. lets remove this line as well.

If there are no expected results, remove the entire clause (line 222, 223, etc.)
Attachment #8979159 - Flags: review?(gbrown) → review-
(Reporter)

Comment 7

10 months ago
Comment on attachment 8979169 [details] [diff] [review]
patch 2 - removed linux and updated mac references

Review of attachment 8979169 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/meta/workers/semantics/structured-clone/shared.html.ini
@@ +225,5 @@
>    [Array primitives]
>      expected:
> +      if (os == "linux") and (processor == "x86") and (bits == 32): TIMEOUT
> +      if not debug and (os == "mac") and (version == "OS X 10.10") and (processor == "x86_64") and (bits == 64): TIMEOUT
> +      if not debug and (os == "linux") and (processor == "x86_64") and (bits == 64): TIMEOUT

just like the previous patch, I think we can remove all 3 of these new clauses.  I had to think for a bit on this.  We currently do not match any of these rules, so I would bet running this with no rules would function just as good as we currently do now.

Like my comments on the previous patch, if there is an expected: block with no conditions to match, remove the test name (in this case [Array primitives], on line 225) and the expected: block starter on line 226.  I suspect this file will be much shorter when that is done.
Attachment #8979169 - Flags: review?(gbrown) → review-
(Assignee)

Comment 8

10 months ago
Attachment #8979159 - Attachment is obsolete: true
Attachment #8979169 - Attachment is obsolete: true
Attachment #8979252 - Flags: review?(jmaher)
(Reporter)

Comment 9

10 months ago
Comment on attachment 8979252 [details] [diff] [review]
patch 1 - removed Mac references

Review of attachment 8979252 [details] [diff] [review]:
-----------------------------------------------------------------

perfect
Attachment #8979252 - Flags: review?(jmaher) → review+
(Assignee)

Comment 10

10 months ago
Attachment #8979261 - Flags: review?(jmaher)
(Reporter)

Comment 11

10 months ago
Comment on attachment 8979261 [details] [diff] [review]
patch 2 - removed linux and mac references

Review of attachment 8979261 [details] [diff] [review]:
-----------------------------------------------------------------

wow, that is a LOT of lines removed
Attachment #8979261 - Flags: review?(jmaher) → review+
(Reporter)

Updated

10 months ago
Keywords: checkin-needed

Comment 12

10 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d53d570eedc
removed OSX references r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/87d810949bdf
removed linux 12.04 and older OSX references r=jmaher
Keywords: checkin-needed

Comment 13

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8d53d570eedc
https://hg.mozilla.org/mozilla-central/rev/87d810949bdf
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.