1461978 - remove old osx 10.6 references in manifest files

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we run our automation on osx 10.10, not 10.6 or other lower versions.

We can remove references to older version in these manifest files:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/workers/semantics/structured-clone/dedicated.html.ini#224

and this file has many references:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/workers/semantics/structured-clone/shared.html.ini

in addition there are references to linux 12.04 which we can remove

Comment 1

[Andreea Pavel [:apavel]]

Attachment: removed osX reference

Comment 2

[Andreea Pavel [:apavel]]

Attachment: removed other refrences

Comment 3

[Andreea Pavel [:apavel]]

Attachment: remove OSX reference

The correct format.

Comment 4

[Andreea Pavel [:apavel]]

Attachment: patch 1 - updated Mac references

Comment 5

[Andreea Pavel [:apavel]]

Attachment: patch 2 - removed linux and updated mac references

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8979159 [details] [diff] [review]
patch 1 - updated Mac references

Review of attachment 8979159 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/meta/workers/semantics/structured-clone/dedicated.html.ini
@@ +221,4 @@
>  
>    [Number 0.2]
>      expected:
> +      if not debug and (os == "mac") and (version == "OS X 10.10") and (processor == "x86_64") and (bits == 64): TIMEOUT

I assume this runs successfully on osx 10.10 as there are no references to TIMEOUT for 10.10, only earlier versions. lets remove this line as well.

If there are no expected results, remove the entire clause (line 222, 223, etc.)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8979169 [details] [diff] [review]
patch 2 - removed linux and updated mac references

Review of attachment 8979169 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/meta/workers/semantics/structured-clone/shared.html.ini
@@ +225,5 @@
>    [Array primitives]
>      expected:
> +      if (os == "linux") and (processor == "x86") and (bits == 32): TIMEOUT
> +      if not debug and (os == "mac") and (version == "OS X 10.10") and (processor == "x86_64") and (bits == 64): TIMEOUT
> +      if not debug and (os == "linux") and (processor == "x86_64") and (bits == 64): TIMEOUT

just like the previous patch, I think we can remove all 3 of these new clauses.  I had to think for a bit on this.  We currently do not match any of these rules, so I would bet running this with no rules would function just as good as we currently do now.

Like my comments on the previous patch, if there is an expected: block with no conditions to match, remove the test name (in this case [Array primitives], on line 225) and the expected: block starter on line 226.  I suspect this file will be much shorter when that is done.

Comment 8

[Andreea Pavel [:apavel]]

Attachment: patch 1 - removed Mac references

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8979252 [details] [diff] [review]
patch 1 - removed Mac references

Review of attachment 8979252 [details] [diff] [review]:
-----------------------------------------------------------------

perfect

Comment 10

[Andreea Pavel [:apavel]]

Attachment: patch 2 - removed linux and mac references

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8979261 [details] [diff] [review]
patch 2 - removed linux and mac references

Review of attachment 8979261 [details] [diff] [review]:
-----------------------------------------------------------------

wow, that is a LOT of lines removed

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d53d570eedc
removed OSX references r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/87d810949bdf
removed linux 12.04 and older OSX references r=jmaher

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8d53d570eedc
https://hg.mozilla.org/mozilla-central/rev/87d810949bdf