1461975 - remove old osx 10.6 references in manifest files

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we run our test automation on osx 10.10.  We have old references to 10.6, 10.8, etc. in our manifest files.

we can remove:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_text_while_paused.html.ini#6

^ and in that file we can remove win 5.1.* and linux 12.04 *


in addition there is another file with similar conditions to be removed:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/dom_override_remove_cue_while_paused.html.ini#8

Comment 1

[Natalia Csoregi [:nataliaCs]]

Attachment: bug1461975_cue_text.patch

Comment 2

[Natalia Csoregi [:nataliaCs]]

Attachment: bug1461975_remove_cue.patch

Comment 3

[Natalia Csoregi [:nataliaCs]]

(In reply to Natalia Csoregi [:nataliaCs] from comment #2)
> Created attachment 8979763 [details] [diff] [review]
> bug1461975_remove_cue.patch

  I was not sure which one is the current version for Win, so I left ""if not debug and (os == "win") and (version == "6.2.9200") "" untouched (according to my friend wiki, 6.1 and newer are the current ones).

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8979762 [details] [diff] [review]
bug1461975_cue_text.patch

Review of attachment 8979762 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_text_while_paused.html.ini
@@ +3,4 @@
>    refurl: /webvtt/rendering/cues-with-video/processing-model/dom_override_cue_text_while_paused-ref.html
>    disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1018936
>    expected:
> +     TIMEOUT

Line indentation changed by 1 space. Please keep that unchanged.

Comment 5

[Natalia Csoregi [:nataliaCs]]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #4)
> Comment on attachment 8979762 [details] [diff] [review]
> bug1461975_cue_text.patch
> 
> Review of attachment 8979762 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> :::
> testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/
> dom_override_cue_text_while_paused.html.ini
> @@ +3,4 @@
> >    refurl: /webvtt/rendering/cues-with-video/processing-model/dom_override_cue_text_while_paused-ref.html
> >    disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1018936
> >    expected:
> > +     TIMEOUT
> 
> Line indentation changed by 1 space. Please keep that unchanged.

sorry about that, doing it again rn

Comment 6

[Natalia Csoregi [:nataliaCs]]

Attachment: bug1461975_cue_text.patch

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8979763 [details] [diff] [review]
bug1461975_remove_cue.patch

Review of attachment 8979763 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/dom_override_remove_cue_while_paused.html.ini
@@ +4,3 @@
>    disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1018936
>    expected:
>      if not debug and (os == "win") and (version == "6.2.9200") and (processor == "x86_64") and (bits == 64): FAIL

this is great.  Technically we do not run 6.2.9200 anymore (that is windows 8), so you could remove line 6 as well.  We can clean this up later.  Your choice if you want to redo this patch.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8979767 [details] [diff] [review]
bug1461975_cue_text.patch

Review of attachment 8979767 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 9

[Natalia Csoregi [:nataliaCs]]

Attachment: bug1461975_remove_cue.patch

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8979770 [details] [diff] [review]
bug1461975_remove_cue.patch

Review of attachment 8979770 [details] [diff] [review]:
-----------------------------------------------------------------

excellent

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9869fefc342c
Removed old references to OSX10, Win5.1 and Linux12.04 on dom_override_cue_text_while_paused.html.ini. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/94510eda31d4
Removed old references for OSX10.6 and Win5.1,6.2 on dom_override_remove_cue_while_paused.html.ini. r=jmaher

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9869fefc342c
https://hg.mozilla.org/mozilla-central/rev/94510eda31d4