1462004 - Port | Bug 1430023 - Get rid of some remaining localstore.rdf code| - rdf/datasource/nsLocalStore.cpp:377:33: error: 'NS_APP_LOCALSTORE_50_FILE' was not declared in this scope

Status: RESOLVED FIXED

(MailNews Core :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

We recently forked RDF to comm-central.

Bug 1430023 now removed remaining localstore functionality incl. this define:
https://hg.mozilla.org/mozilla-central/rev/ba79a9e472c0#l12.12
-#define NS_APP_LOCALSTORE_50_FILE               "LclSt"
and underlying functionality.

This is still used in rdf/datasource/nsLocalStore.cpp:377, hence, we're busted.

We need to investigate since the surrounding code can just be removed, potentially all of nsLocalStore.cpp.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1462004-use-hardcoded-string.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3566433f12f1
Port bug 1430023: Use hard-coded string instead of NS_APP_LOCALSTORE_50_FILE. rs=bustage-fix

Comment 3

[Jorg K (CEST = GMT+2)]

Since RDF is doomed and life is short, we'll just leave it at this and won't spend more time on investigating how much of nsLocalStore.cpp could be removed.

Comment 4

[:aceman]

Comment on attachment 8976180 [details] [diff] [review]
1462004-use-hardcoded-string.patch

Review of attachment 8976180 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, thanks.