1462100 - Disabling Sandbox Exports causes invalid conversions

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Tom Ritter [:tjr]]

I accidentally omitted part of Tor's patch when fixing Bug 1460882 and apparently didn't build an x86 esr60 branch like I thought I did.

The error is below, and the fix is simply to explicitly cast to void*

error: invalid conversion from 'NTSTATUS (__attribute__((__stdcall__)) *)(NtCreateFileFunction, PHANDLE, ACCESS_MASK, POBJECT_ATTRIBUTES, PIO_STATUS_BLOCK, PLARGE_INTEGER, ULONG, ULONG, ULONG, ULONG, PVOID, ULONG) {aka long int (__attribute__((__stdcall__)) *)(long int (__attribute__((__stdcall__)) *)(void**, long unsigned int, _OBJECT_ATTRIBUTES*, _IO_STATUS_BLOCK*, _LARGE_INTEGER*, long unsigned int, long unsigned int, long unsigned int, long unsigned int, void*, long unsigned int), void**, long unsigned int, _OBJECT_ATTRIBUTES*, _IO_STATUS_BLOCK*, _LARGE_INTEGER*, long unsigned int, long unsigned int, long unsigned int, long unsigned int, void*, long unsigned int)}' to 'const void*' [-fpermissive]

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1462100 Cast to void* to avoid conversion errors on MinGW, which does not do the automatic conversion like msvc

Review commit: https://reviewboard.mozilla.org/r/244464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244464/

Comment 2

[Bob Owen (:bobowen)]

Comment on attachment 8976282 [details]
Bug 1462100 Cast to void* to avoid conversion errors on MinGW, which does not do the automatic conversion like msvc

https://reviewboard.mozilla.org/r/244464/#review250624

Can we have a patch in security/sandbox/chromium-shim/patches/with_update/ please and an entry in patch_order.txt.

Comment 3

[Tom Ritter [:tjr]]

Attachment: Bug 1462100 Add the 'cast to void*' MinGW sandbox patch to the chromium patchlist

Review commit: https://reviewboard.mozilla.org/r/244678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244678/

Comment 4

[Tom Ritter [:tjr]]

Comment on attachment 8976282 [details]
Bug 1462100 Cast to void* to avoid conversion errors on MinGW, which does not do the automatic conversion like msvc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244464/diff/1-2/

Comment 5

[Bob Owen (:bobowen)]

Comment on attachment 8976282 [details]
Bug 1462100 Cast to void* to avoid conversion errors on MinGW, which does not do the automatic conversion like msvc

https://reviewboard.mozilla.org/r/244464/#review250736

Comment 6

[Bob Owen (:bobowen)]

Comment on attachment 8976580 [details]
Bug 1462100 Add the 'cast to void*' MinGW sandbox patch to the chromium patchlist

https://reviewboard.mozilla.org/r/244678/#review250738

Comment 7

[Tom Ritter [:tjr]]

Woops, need to rebase.

Comment 8

[Tom Ritter [:tjr]]

Attachment: esr60.patch

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.

Comment 9

[Tom Ritter [:tjr]]

Comment on attachment 8976282 [details]
Bug 1462100 Cast to void* to avoid conversion errors on MinGW, which does not do the automatic conversion like msvc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244464/diff/2-3/

Comment 10

[Tom Ritter [:tjr]]

Comment on attachment 8976580 [details]
Bug 1462100 Add the 'cast to void*' MinGW sandbox patch to the chromium patchlist

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244678/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d4ac4eb034c
Cast to void* to avoid conversion errors on MinGW, which does not do the automatic conversion like msvc r=bobowen
https://hg.mozilla.org/integration/autoland/rev/72edf78c24ef
Add the 'cast to void*' MinGW sandbox patch to the chromium patchlist r=bobowen

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8d4ac4eb034c
https://hg.mozilla.org/mozilla-central/rev/72edf78c24ef

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8976588 [details] [diff] [review]
esr60.patch

mingw fix, approved for 60.1esr

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/15638bdb5acb