Closed Bug 1460882 Opened 3 years ago Closed 3 years ago

x86 MinGW Sandbox does not run with SANDBOX_EXPORTS

Categories

(Core :: Security: Process Sandboxing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Now that we have a running browser, we determined that the x86 sandbox doesn't work.  Fortunetly, the fix was in Tor's repository: https://gitweb.torproject.org/tor-browser.git/patch/?id=c9b10a8

Primarily: disable SANDBOX_EXPORTS
Comment on attachment 8975003 [details]
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build

https://reviewboard.mozilla.org/r/243388/#review249294
Attachment #8975003 - Flags: review?(bobowencode) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4d7c95672b79
Disable SANDBOX_EXPORTS for the MinGW Build r=bobowen
Keywords: checkin-needed
Comment on attachment 8975003 [details]
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8975003 - Flags: approval-mozilla-esr60?
https://hg.mozilla.org/mozilla-central/rev/4d7c95672b79
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment on attachment 8975003 [details]
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build

mingw build fix, approved for 60.1esr
Attachment #8975003 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Ah, that's bug 1462100.
Flags: needinfo?(tom)
You need to log in before you can comment on or make changes to this bug.