59 bytes, text/x-review-board-request
Now that we have a running browser, we determined that the x86 sandbox doesn't work. Fortunetly, the fix was in Tor's repository: https://gitweb.torproject.org/tor-browser.git/patch/?id=c9b10a8 Primarily: disable SANDBOX_EXPORTS
The rational for this change can be found in https://trac.torproject.org/projects/tor/ticket/16010
Comment on attachment 8975003 [details] Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build https://reviewboard.mozilla.org/r/243388/#review249294
Attachment #8975003 - Flags: review?(bobowencode) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4d7c95672b79 Disable SANDBOX_EXPORTS for the MinGW Build r=bobowen
Comment on attachment 8975003 [details] Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build [Approval Request Comment] This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60. This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8975003 - Flags: approval-mozilla-esr60?
Comment on attachment 8975003 [details] Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build mingw build fix, approved for 60.1esr
Attachment #8975003 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Backed out from ESR60 for breaking mingw builds. https://hg.mozilla.org/releases/mozilla-esr60/rev/035ad5ecd97ee8a2e3beb9176e9d98d1163b1c75 https://treeherder.mozilla.org/logviewer.html#?job_id=179729071&repo=mozilla-esr60
Ah, that's bug 1462100.
You need to log in before you can comment on or make changes to this bug.