x86 MinGW Sandbox does not run with SANDBOX_EXPORTS

RESOLVED FIXED in Firefox -esr60

Status

()

defect
RESOLVED FIXED
Last year
6 months ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

(Blocks 2 bugs)

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox62 fixed)

Details

Attachments

(1 attachment)

Now that we have a running browser, we determined that the x86 sandbox doesn't work.  Fortunetly, the fix was in Tor's repository: https://gitweb.torproject.org/tor-browser.git/patch/?id=c9b10a8

Primarily: disable SANDBOX_EXPORTS
The rational for this change can be found in https://trac.torproject.org/projects/tor/ticket/16010
Blocks: 1460885
Comment on attachment 8975003 [details]
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build

https://reviewboard.mozilla.org/r/243388/#review249294
Attachment #8975003 - Flags: review?(bobowencode) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4d7c95672b79
Disable SANDBOX_EXPORTS for the MinGW Build r=bobowen
Keywords: checkin-needed
Comment on attachment 8975003 [details]
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8975003 - Flags: approval-mozilla-esr60?
https://hg.mozilla.org/mozilla-central/rev/4d7c95672b79
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Blocks: 1462100
Comment on attachment 8975003 [details]
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build

mingw build fix, approved for 60.1esr
Attachment #8975003 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Ah, that's bug 1462100.
Flags: needinfo?(tom)
Blocks: 1520310
You need to log in before you can comment on or make changes to this bug.