1462124 - Switch .addonInfo to an async API in snippets targeting

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Kate Hudson :k88hudson]

After discussing with the add-ons team, it looks like the reason no disabled information is getting included with .addonInfo is that we are checking on startup. If we move this to an async api we should be able to get the full information on subsequent calls after startup.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Hi Kate, do we have an ETA on this?

Comment 2

[Kate Hudson :k88hudson]

I'm going to aim for early next week for this

Comment 3

[Giorgos Logiotatidis [:giorgos]]

(In reply to Kate Hudson :k88hudson from comment #2)
> I'm going to aim for early next week for this

Just making sure that I understand correctly: So that means Fx62?

Comment 4

[Kate Hudson :k88hudson]

I think I'll probably be able to uplift to 61 if the changes aren't too large. I'll let you know if I'm unable to do that

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4163

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/de57703ba2a5f21282c5344f4b4642c17184c8f5
Bug 1462124 - Switch .addonInfo to an async API in snippets targeting

https://github.com/mozilla/activity-stream/commit/bfd46426727cfb7a22fa70d69307639ad24f686f
Merge pull request #4163 from k88hudson/bug1462124

Bug 1462124 - Switch .addonInfo to an async API in snippets targeting

Comment 7

[Giorgos Logiotatidis [:giorgos]]

(In reply to Kate Hudson :k88hudson from comment #4)
> I think I'll probably be able to uplift to 61 if the changes aren't too
> large. I'll let you know if I'm unable to do that


Thanks for the fix Kate! Were those changes uplifted? Which version of Firefox has them?

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/609a288fe314

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4188

Comment 10

[Kate Hudson :k88hudson]

This is available in 62. We haven't uplifted it yet, there was another bug I'm waiting to uplift first but I'll see if we can do it after it merges