Closed Bug 1462124 Opened 2 years ago Closed 2 years ago

Switch .addonInfo to an async API in snippets targeting

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 62
Iteration:
62.2 - Jun 4
Tracking Status
firefox62 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

(Whiteboard: [has-pr])

Attachments

(2 files)

After discussing with the add-ons team, it looks like the reason no disabled information is getting included with .addonInfo is that we are checking on startup. If we move this to an async api we should be able to get the full information on subsequent calls after startup.
Assignee: nobody → khudson
Hi Kate, do we have an ETA on this?
Flags: needinfo?(khudson)
I'm going to aim for early next week for this
Flags: needinfo?(khudson)
Iteration: --- → 62.2 - Jun 4
Priority: -- → P1
(In reply to Kate Hudson :k88hudson from comment #2)
> I'm going to aim for early next week for this

Just making sure that I understand correctly: So that means Fx62?
Flags: needinfo?(khudson)
I think I'll probably be able to uplift to 61 if the changes aren't too large. I'll let you know if I'm unable to do that
Flags: needinfo?(khudson)
Severity: normal → enhancement
Whiteboard: [has-pr]
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/de57703ba2a5f21282c5344f4b4642c17184c8f5
Bug 1462124 - Switch .addonInfo to an async API in snippets targeting

https://github.com/mozilla/activity-stream/commit/bfd46426727cfb7a22fa70d69307639ad24f686f
Merge pull request #4163 from k88hudson/bug1462124

Bug 1462124 - Switch .addonInfo to an async API in snippets targeting
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1465172
(In reply to Kate Hudson :k88hudson from comment #4)
> I think I'll probably be able to uplift to 61 if the changes aren't too
> large. I'll let you know if I'm unable to do that


Thanks for the fix Kate! Were those changes uplifted? Which version of Firefox has them?
Flags: needinfo?(khudson)
This is available in 62. We haven't uplifted it yet, there was another bug I'm waiting to uplift first but I'll see if we can do it after it merges
Flags: needinfo?(khudson)
See Also: → 1494232
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.