1462160 - TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_AddonRepository_cache.js and five more

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_AddonRepository_cache.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_AddonRepository_paging.js | xpcshell return code: 0
TEST-UNEXPECTED-TIMEOUT | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_backgroundupdate.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_compatoverrides.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sourceURI.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_blocklistchange.js | Test timed out

First seen Wed, May 16, 2018 22:14:43

M-C last good: 380cf87c1ee3966dd94499942b73085754
M-C first bad: d5b463283f3983c0e7c9d78cb8559f89b5
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=380cf87c1ee3966dd94499942b73085754&tochange=d5b463283f3983c0e7c9d78cb8559f89b5

Since these are mostly timeouts, the Xpcshell run now takes 45 minutes instead of 10 minutes :-(
Not a development enhancer :-((

Comment 1

[Jorg K (CEST = GMT+2)]

Tests already fail locally at M-C 3c9d69736f4a, so smaller range:
M-C last good: 380cf87c1ee3
M-C first bad: 3c9d69736f4a
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=380cf87c1ee3&tochange=3c9d69736f4a

Running this locally, I get an error [nsIPrefBranch.getBoolPref] at AddonManager.jsm:1251 which is:
  if (!Services.prefs.getBoolPref(PREF_SYS_ADDON_UPDATE_ENABLED)) {
which is
const PREF_SYS_ADDON_UPDATE_ENABLED   = "extensions.systemAddon.update.enabled"
which was added here:
extensions.systemAddon.update.enabled

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Probably a matter of porting the pref changes from bug 1428459

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1462160-extensions.systemAddon.update.enabled.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6325c7433eb4
Add preference extensions.systemAddon.update.enabled needed in toolkit tests. rs=bustage-fix

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8976357 [details] [diff] [review]
1462160-extensions.systemAddon.update.enabled.patch

No idea whether we should have true or false. All tests pass locally with false. FF also has a
  pref("extensions.systemAddon.update.url", "https:// ...");
so maybe using 'true' would lead to this pref being retrieved. I haven't tried.

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Philipp Kewisch [:Fallen]  from comment #2)
> Probably a matter of porting the pref changes from bug 1428459
Yes, I did and it works.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8976357 [details] [diff] [review]
1462160-extensions.systemAddon.update.enabled.patch

Actually Philipp might know whether to use 'true' or 'false' here. Please note comment #5.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8976357 [details] [diff] [review]
1462160-extensions.systemAddon.update.enabled.patch

We don't have system add-ons (yet), but when we do we'd need to set it to true. If we can do that now and make sure the tests don't fail that would be better.

Comment 9

[Jorg K (CEST = GMT+2)]

I'll check it.

Comment 10

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=63909ad4cfa9cf1813d0730809664145bf7ab59f

Comment 11

[Jorg K (CEST = GMT+2)]

Attachment: 1462160-follow-up.patch

It seems to work with the preference at 'true', so let's do that.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/212529ee949c
Follow-up: Set extensions.systemAddon.update.enabled to true. r=me