1462179 - Follow-up to WPT RTCPeerConnection-setRemoteDescription.html patch

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

+++ This bug was initially created as a clone of Bug #1461563 +++

A follow-up from feedback in https://github.com/w3c/web-platform-tests/pull/11031:

 1. Add t.step_func() to onssignalingstate callback
 
 2. We shouldn't test the "closed" signalingstate event, since it's not to spec,
    even though both Firefox and Chrome fire it.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1462179: Add t.step_func() to calllback and remove closed state test.

Review commit: https://reviewboard.mozilla.org/r/244538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244538/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8976375 [details]
Bug 1462179: Add t.step_func() to calllback and remove closed state test.

https://reviewboard.mozilla.org/r/244538/#review250688

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f67ebc5b1596
Add t.step_func() to calllback and remove closed state test. r=bwc

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/11054 for changes under testing/web-platform/tests

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f67ebc5b1596

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/w3c/web-platform-tests/pull/11054
* continuous-integration/travis-ci/pr (https://travis-ci.org/w3c/web-platform-tests/builds/380386817?utm_source=github_status&utm_medium=notification)

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged