1461563 - WPT RTCPeerConnection-setRemoteDescription.html is incorrect with transceivers (timeout)

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Two things wrong with webrtc/RTCPeerConnection-setRemoteDescription.html:

First, it times out in Firefox without any info about which test(s) are failing.

This is caused by the helper function test_state_change_event(). Its design as a separate test running in the background makes it vulnerable to hangs when regular test failures prevent all state changes from finishing. Hangs obscure results. 

Avoiding that function, we find the following test fails:

  "Switching role from offerer to answerer after going back to stable state should succeed"
  assert_equals: Expect m=audio line to be present in generated SDP expected 0 but got 1

  generateOffer/<@http://web-platform.test:8000/webrtc/RTCPeerConnection-helper.js:139:7
  promise callback*generateOffer@http://web-platform.test:8000/webrtc/RTCPeerConnection-helper.js:130:10
  @http://web-platform.test:8000/webrtc/RTCPeerConnection-setRemoteDescription.html:110:19

The test is essentially expecting

  await pc.createOffer({ offerToReceiveAudio: true })
  let offer = await pc.createOffer();

...to produce an offer without an audio m-line. This is pre-transceiver behavior and no longer to spec, since {offerToReceiveAudio: true} now implicitly creates a transceiver which sticks around.

Updating the test to spec fixes this assert in Firefox.

The test still fails in Firefox a few asserts down, revealing a real bug 1461507.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1461563 - Update RTCPeerConnection-setRemoteDescription.html to spec, and avoid hang-prone test_state_change_event().

Review commit: https://reviewboard.mozilla.org/r/243950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243950/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8975724 [details]
Bug 1461563 - Update RTCPeerConnection-setRemoteDescription.html to spec, and avoid hang-prone test_state_change_event().

https://reviewboard.mozilla.org/r/243950/#review250292

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d34216b7f19
Update RTCPeerConnection-setRemoteDescription.html to spec, and avoid hang-prone test_state_change_event(). r=bwc

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/11031 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/w3c/web-platform-tests/pull/11031
* continuous-integration/travis-ci/pr (https://travis-ci.org/w3c/web-platform-tests/builds/379751467?utm_source=github_status&utm_medium=notification)

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1d34216b7f19

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged